From: "J, KEERTHY" <j-keerthy@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: RE: [PATCH V2] Regulator: Reorder the min max assignment in the sequence of regulator_set_voltage function
Date: Mon, 11 Feb 2013 17:36:23 +0000 [thread overview]
Message-ID: <DC88CAD03C0052499C1907B327FC63229B976F@DBDE01.ent.ti.com> (raw)
In-Reply-To: <20130211170525.GK4607@opensource.wolfsonmicro.com>
> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Monday, February 11, 2013 10:35 PM
> To: J, KEERTHY
> Cc: linux-kernel@vger.kernel.org; lgirdwood@gmail.com
> Subject: Re: [PATCH V2] Regulator: Reorder the min max assignment in
> the sequence of regulator_set_voltage function
>
> On Mon, Feb 11, 2013 at 12:19:34PM +0530, J Keerthy wrote:
>
> > The min and max values for regulators are getting assigned before
> > actually the voltage is set. So making sure that min and max values
> > are assigned only if the voltage is successfully set else keeping the
> > last successfully set voltage's min and max values.
>
> > This is boot tested on OMAP4430 and OMAP4460 boards.
>
> This seems fine but doesn't apply against topic/core or -next, can you
> please regenerate against topic/core and resend?
Ok. I will rebase.
>
> > V2: Fixed comment from Mark. Introduced local variables to hold
> > current min and max values.
>
> Don't include things like this in the changelog, include them after the
> --- as covered in SubmittingPatches.
Ok.
next prev parent reply other threads:[~2013-02-11 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 6:49 [PATCH V2] Regulator: Reorder the min max assignment in the sequence of regulator_set_voltage function J Keerthy
2013-02-11 17:05 ` Mark Brown
2013-02-11 17:36 ` J, KEERTHY [this message]
2013-02-12 11:11 ` J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC88CAD03C0052499C1907B327FC63229B976F@DBDE01.ent.ti.com \
--to=j-keerthy@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).