From: "Luck, Tony" <tony.luck@intel.com>
To: "Russell King" <rmk@arm.linux.org.uk>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Restore module support.
Date: Fri, 7 Feb 2003 13:15:54 -0800 [thread overview]
Message-ID: <DD755978BA8283409FB0087C39132BD1A07CA5@fmsmsx404.fm.intel.com> (raw)
Russell King wrote:
> On Fri, Feb 07, 2003 at 10:43:19AM -0800, Luck, Tony wrote:
> > > (2) has the disadvantage that its touching
> non-architecture specific
> > > code, but this is the option I'd prefer due to the
> obvious performance
> > > advantage. However, I'm afraid that it isn't worth the
> effort to fix
> > > up vmalloc and /proc/kcore. vmalloc fix appears simple,
> but /proc/kcore
> > > has issues (anyone know what KCORE_BASE is all about?)
> >
> > KCORE_BASE is my fault ... it was an attempt to fix the "modules
> > below PAGE_OFFSET" problem for the ia64 port. For a few nanoseconds
> > the code just here looked like this:
> >
> > #if VMALLOC_START < PAGE_OFFSET
> > #define KCORE_BASE VMALLOC_START
> > #else
> > #define KCORE_BASE PAGE_OFFSET
> > #endif
>
> Ah, ok. What I'm thinking of is something like the following
> (untested
> and probably improperly thought out patch...):
>
> --- orig/fs/proc/kcore.c Sat Nov 2 18:58:18 2002
> +++ linux/fs/proc/kcore.c Fri Feb 7 19:48:35 2003
> @@ -99,7 +99,10 @@
> }
> #else /* CONFIG_KCORE_AOUT */
>
> +#ifndef KCORE_BASE
> #define KCORE_BASE PAGE_OFFSET
> +) < #define in_vmlist_region(x) ((x) >= VMALLOC_START && (x
> VMALLOC_END)
> +#endif
>
> #define roundup(x, y) ((((x)+((y)-1))/(y))*(y))
>
> @@ -394,7 +397,7 @@
> tsz = buflen;
>
> while (buflen) {
> - if ((start >= VMALLOC_START) && (start < VMALLOC_END)) {
> + if (in_vmlist_region(start)) {
> char * elf_buf;
> struct vm_struct *m;
> unsigned long curstart = start;
>
> An architecture could then define KCORE_BASE and in_vmlist_region()
> alongside their VMALLOC_START definition if they needed to change
> them.
Looks pretty good. What's the motivation for the in_vmlist_region()?
I don't think that I need that for ia64 ... so it might be better to
have separate #ifdefs:
#ifndef KCORE_BASE
#define KCORE_BASE PAGE_OFFSET
endif
#ifndef in_vmlist_region
#define in_vmlist_region(x) ((x) >= VMALLOC_START && (x < VMALLOC_END))
#endif
-Tony
next reply other threads:[~2003-02-07 21:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 21:15 Luck, Tony [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-02-07 18:43 [PATCH] Restore module support Luck, Tony
2003-02-07 19:50 ` Russell King
2003-02-07 8:26 Rusty Russell
2003-02-07 10:05 ` Russell King
2003-02-08 4:32 ` Rusty Russell
2003-02-06 23:49 Adam J. Richter
2003-02-04 8:51 [PATCH] Module alias and device table support Rusty Russell
2003-02-06 23:09 ` [PATCH] Restore module support Roman Zippel
2003-02-06 23:25 ` Greg KH
2003-02-07 0:01 ` Roman Zippel
2003-02-07 4:06 ` Greg KH
2003-02-07 9:39 ` Roman Zippel
2003-02-07 18:01 ` Roman Zippel
2003-02-07 0:10 ` Russell King
2003-02-07 4:53 ` Rusty Russell
2003-02-07 10:03 ` Russell King
2003-02-07 6:12 ` Kai Germaschewski
2003-02-07 9:46 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD755978BA8283409FB0087C39132BD1A07CA5@fmsmsx404.fm.intel.com \
--to=tony.luck@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).