From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: Andi Kleen <andi@firstfloor.org>, "x86@kernel.org" <x86@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>
Subject: RE: [PATCH] x86/microcode/intel: Quieten down microcode updates on large systems
Date: Thu, 9 Jun 2016 04:34:35 +0000 [thread overview]
Message-ID: <DF4PR84MB0169F74AA72FF7576F5CB370AB5F0@DF4PR84MB0169.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <1464729764-108209-1-git-send-email-andi@firstfloor.org>
> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Andi Kleen
> Sent: Tuesday, May 31, 2016 4:23 PM
> To: x86@kernel.org
> Cc: linux-kernel@vger.kernel.org; Andi Kleen <ak@linux.intel.com>
> Subject: [PATCH] x86/microcode/intel: Quieten down microcode updates
> on large systems
...
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c
> @@ -808,8 +809,14 @@ static int collect_cpu_info(int cpu_num, struct
> cpu_signature *csig)
> }
>
> csig->rev = c->microcode;
> - pr_info("CPU%d sig=0x%x, pf=0x%x, revision=0x%x\n",
> - cpu_num, csig->sig, csig->pf, csig->rev);
> +
> + /* No extra locking on prev, races are harmless. */
> + if (csig->sig != prev.sig || csig->pf != prev.pf ||
> + csig->rev != prev.rev) {
> + pr_info("CPU sig=0x%x, pf=0x%x, revision=0x%x\n",
> + csig->sig, csig->pf, csig->rev);
> + prev = *csig;
> + }
...
> - pr_info("CPU%d updated to revision 0x%x, date = %04x-%02x-
> %02x\n",
> - cpu, val[1],
> - mc->hdr.date & 0xffff,
> - mc->hdr.date >> 24,
> - (mc->hdr.date >> 16) & 0xff);
> + if (val[1] != prev_rev) {
> + pr_info("CPU updated to revision 0x%x, date = %04x-%02x-
> %02x\n",
"CPU(s)" would help convey that the messages now apply to one or
more CPUs.
next prev parent reply other threads:[~2016-06-09 4:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 21:22 [PATCH] x86/microcode/intel: Quieten down microcode updates on large systems Andi Kleen
2016-06-09 4:34 ` Elliott, Robert (Persistent Memory) [this message]
2016-06-09 15:47 ` Henrique de Moraes Holschuh
2016-06-09 13:41 Andi Kleen
2016-06-09 23:58 ` Henrique de Moraes Holschuh
2016-06-10 9:54 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF4PR84MB0169F74AA72FF7576F5CB370AB5F0@DF4PR84MB0169.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).