linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: KY Srinivasan <kys@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Haiyang Zhang" <haiyangz@microsoft.com>
Subject: RE: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs persistent
Date: Wed, 10 Aug 2016 19:00:37 +0000	[thread overview]
Message-ID: <DM2PR0301MB07835532C07EA99BCB502C68A01D0@DM2PR0301MB0783.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1470732379-5013-1-git-send-email-vkuznets@redhat.com>



> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Tuesday, August 9, 2016 1:46 AM
> To: devel@linuxdriverproject.org
> Cc: linux-kernel@vger.kernel.org; Haiyang Zhang <haiyangz@microsoft.com>;
> KY Srinivasan <kys@microsoft.com>
> Subject: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs persistent
> 
> Bus ids for VMBus devices in /sys/bus/vmbus/devices/ are not guaranteed
> to be persistent across reboot or kernel restart and this causes problems
> for some tools. E.g. kexec tools use these ids to identify NIC on kdump.
> Fix the issue by using relid from channel offer as the unique id instead
> of an auto incremented counter.

Relids are not persistent. It is only valid between a channel offer message and a relid released message (or an unload or initiate contact message, which invalidates all channels). This is an opaque number that the root generates and uses to track channels. There is no guarantee that the same type of channel (networking, storage, etc) will get the same relid on each reboot.

Regards,

K. Y
> 
> Vitaly Kuznetsov (2):
>   Drivers: hv: make VMBus bus ids persistent
>   Drivers: hv: get rid of id in struct vmbus_channel
> 
>  drivers/hv/channel_mgmt.c | 2 --
>  drivers/hv/vmbus_drv.c    | 2 +-
>  include/linux/hyperv.h    | 3 ---
>  3 files changed, 1 insertion(+), 6 deletions(-)
> 
> --
> 2.7.4

  parent reply	other threads:[~2016-08-10 20:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09  8:46 [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs persistent Vitaly Kuznetsov
2016-08-09  8:46 ` [PATCH 1/2] Drivers: hv: make VMBus bus ids persistent Vitaly Kuznetsov
2016-08-09  8:46 ` [PATCH 2/2] Drivers: hv: get rid of id in struct vmbus_channel Vitaly Kuznetsov
2016-08-10 19:00 ` KY Srinivasan [this message]
2016-08-11  9:16   ` [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs persistent Vitaly Kuznetsov
2016-08-12 14:10     ` KY Srinivasan
2016-08-15 16:11       ` Vitaly Kuznetsov
2016-08-17 16:33         ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM2PR0301MB07835532C07EA99BCB502C68A01D0@DM2PR0301MB0783.namprd03.prod.outlook.com \
    --to=kys@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).