From: "Yuan, Perry" <Perry.Yuan@amd.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"Huang, Ray" <Ray.Huang@amd.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>
Cc: "Sharma, Deepak" <Deepak.Sharma@amd.com>,
"Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Huang, Shimmer" <Shimmer.Huang@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
"Karny, Wyes" <Wyes.Karny@amd.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v8 12/13] cpufreq: amd-pstate: convert sprintf with sysfs_emit()
Date: Sun, 25 Dec 2022 16:42:35 +0000 [thread overview]
Message-ID: <DM4PR12MB5278DDD511B2708BEB3DB92B9CEF9@DM4PR12MB5278.namprd12.prod.outlook.com> (raw)
In-Reply-To: <8c6d4a0a-065d-cd01-7799-5f6603c0ebb8@amd.com>
[AMD Official Use Only - General]
Hi Mario.
> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@amd.com>
> Sent: Tuesday, December 20, 2022 7:31 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>; rafael.j.wysocki@intel.com; Huang,
> Ray <Ray.Huang@amd.com>; viresh.kumar@linaro.org
> Cc: Sharma, Deepak <Deepak.Sharma@amd.com>; Fontenot, Nathan
> <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Huang, Shimmer
> <Shimmer.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Meng,
> Li (Jassmine) <Li.Meng@amd.com>; Karny, Wyes <Wyes.Karny@amd.com>;
> linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v8 12/13] cpufreq: amd-pstate: convert sprintf with
> sysfs_emit()
>
> On 12/19/2022 00:40, Perry Yuan wrote:
> > replace the sprintf with a more generic sysfs_emit function
> >
> > No potential function impact
>
> Anything is possible! "No intended functional impact." I believe is what you
> meant =)
>
> >
> > Signed-off-by: Perry Yuan <perry.yuan@amd.com>
>
> With commit message fixed:
>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Thanks for your review , all the R-B flags have been picked up in v9 .
And other feedbacks from you have been changed in v9 as well.
Perry.
>
> > ---
> > drivers/cpufreq/amd-pstate.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c
> > b/drivers/cpufreq/amd-pstate.c index e8996e937e63..d8b182614c18
> 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -709,7 +709,7 @@ static ssize_t show_amd_pstate_max_freq(struct
> cpufreq_policy *policy,
> > if (max_freq < 0)
> > return max_freq;
> >
> > - return sprintf(&buf[0], "%u\n", max_freq);
> > + return sysfs_emit(buf, "%u\n", max_freq);
> > }
> >
> > static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct
> > cpufreq_policy *policy, @@ -722,7 +722,7 @@ static ssize_t
> show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli
> > if (freq < 0)
> > return freq;
> >
> > - return sprintf(&buf[0], "%u\n", freq);
> > + return sysfs_emit(buf, "%u\n", freq);
> > }
> >
> > /*
> > @@ -737,7 +737,7 @@ static ssize_t
> show_amd_pstate_highest_perf(struct
> > cpufreq_policy *policy,
> >
> > perf = READ_ONCE(cpudata->highest_perf);
> >
> > - return sprintf(&buf[0], "%u\n", perf);
> > + return sysfs_emit(buf, "%u\n", perf);
> > }
> >
> > static ssize_t show_energy_performance_available_preferences(
next prev parent reply other threads:[~2022-12-25 16:43 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 6:40 [PATCH v8 00/13] Implement AMD Pstate EPP Driver Perry Yuan
2022-12-19 6:40 ` [PATCH v8 01/13] ACPI: CPPC: Add AMD pstate energy performance preference cppc control Perry Yuan
2022-12-19 21:09 ` Limonciello, Mario
2022-12-23 2:16 ` Huang Rui
2022-12-23 3:19 ` Yuan, Perry
2022-12-23 9:06 ` Huang Rui
2022-12-25 16:41 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 02/13] Documentation: amd-pstate: add EPP profiles introduction Perry Yuan
2022-12-19 22:37 ` Limonciello, Mario
2022-12-19 6:40 ` [PATCH v8 03/13] cpufreq: intel_pstate: use common macro definition for Energy Preference Performance(EPP) Perry Yuan
2022-12-19 10:51 ` kernel test robot
2022-12-19 11:11 ` kernel test robot
2022-12-20 2:53 ` Mario Limonciello
2022-12-23 3:10 ` Huang Rui
2022-12-23 3:12 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 04/13] cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering Perry Yuan
2022-12-19 22:55 ` Limonciello, Mario
2022-12-19 6:40 ` [PATCH v8 05/13] cpufreq: amd-pstate: optimize driver working mode selection in amd_pstate_param() Perry Yuan
2022-12-19 10:11 ` kernel test robot
2022-12-19 23:01 ` Limonciello, Mario
2022-12-23 4:23 ` Huang Rui
2022-12-23 9:45 ` Wyes Karny
2022-12-25 16:41 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 06/13] cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors Perry Yuan
2022-12-20 3:09 ` Mario Limonciello
2022-12-23 7:43 ` Huang Rui
2022-12-23 7:52 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 07/13] cpufreq: amd-pstate: implement amd pstate cpu online and offline callback Perry Yuan
2022-12-23 8:11 ` Huang Rui
2022-12-19 6:40 ` [PATCH v8 08/13] cpufreq: amd-pstate: implement suspend and resume callbacks Perry Yuan
2022-12-23 8:12 ` Huang Rui
2022-12-19 6:40 ` [PATCH v8 09/13] cpufreq: amd-pstate: add driver working mode switch support Perry Yuan
2022-12-19 23:38 ` Limonciello, Mario
2022-12-23 8:56 ` Huang Rui
2022-12-25 16:41 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 10/13] Documentation: amd-pstate: add amd pstate driver mode introduction Perry Yuan
2022-12-19 23:28 ` Limonciello, Mario
2022-12-19 6:40 ` [PATCH v8 11/13] Documentation: introduce amd pstate active mode kernel command line options Perry Yuan
2022-12-19 23:29 ` Limonciello, Mario
2022-12-19 6:40 ` [PATCH v8 12/13] cpufreq: amd-pstate: convert sprintf with sysfs_emit() Perry Yuan
2022-12-19 23:31 ` Limonciello, Mario
2022-12-25 16:42 ` Yuan, Perry [this message]
2022-12-23 7:45 ` Huang Rui
2022-12-19 6:40 ` [PATCH v8 13/13] Documentation: amd-pstate: introduce new global sysfs attributes Perry Yuan
2022-12-19 22:35 ` Limonciello, Mario
2022-12-20 18:13 ` [PATCH v8 00/13] Implement AMD Pstate EPP Driver Tor Vic
2022-12-20 18:52 ` Tor Vic
2022-12-21 3:08 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5278DDD511B2708BEB3DB92B9CEF9@DM4PR12MB5278.namprd12.prod.outlook.com \
--to=perry.yuan@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Shimmer.Huang@amd.com \
--cc=Wyes.Karny@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).