From: Yuval Mintz <Yuval.Mintz@qlogic.com>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"xie.baoyou@zte.com.cn" <xie.baoyou@zte.com.cn>,
Ariel Elior <Ariel.Elior@qlogic.com>
Subject: RE: [PATCH] qed: mark symbols static where possible
Date: Wed, 7 Sep 2016 11:55:34 +0000 [thread overview]
Message-ID: <DM5PR11MB1723EE385BEB0EFB1AD6CC1497F80@DM5PR11MB1723.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1473247341-1244-1-git-send-email-baoyou.xie@linaro.org>
> We get a few warnings when building kernel with W=1:
> drivers/net/ethernet/qlogic/qed/qed_l2.c:112:5: warning: no previous
> prototype for 'qed_sp_vport_start' [-Wmissing-prototypes]
> ....
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Most of this changes are correct. I have 2 reservations, though:
1. qed_get_vport_stats() is in use in net-next by qed_main.c starting with
6c75424612a7 ("qed: Add support for NCSI statistics."), so we shouldn't
make it static.
[This raises the question of which repository was this patch built against?]
2. Regarding the changes in qed_cxt.c - some of the functions you're turning
into static are going to be used be other files in our pending RoCE driver
submissions [you could say those ARE really missing their prototypes].
I don't have a real objection to this change - I'm just stating that if you'll
change those now to static, we'll probably 'revert' the change in the near
future.
next prev parent reply other threads:[~2016-09-07 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 11:22 [PATCH] qed: mark symbols static where possible Baoyou Xie
2016-09-07 11:55 ` Yuval Mintz [this message]
2016-09-08 0:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB1723EE385BEB0EFB1AD6CC1497F80@DM5PR11MB1723.namprd11.prod.outlook.com \
--to=yuval.mintz@qlogic.com \
--cc=Ariel.Elior@qlogic.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).