* RE: [PATCH V5 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver
[not found] ` <1550837545-10760-3-git-send-email-Tianyu.Lan@microsoft.com>
@ 2019-02-22 15:58 ` Michael Kelley
0 siblings, 0 replies; 3+ messages in thread
From: Michael Kelley @ 2019-02-22 15:58 UTC (permalink / raw)
To: Tianyu Lan
Cc: Tianyu Lan, joro, mchehab+samsung, davem, gregkh, nicolas.ferre,
arnd, linux-kernel, iommu, KY Srinivasan, vkuznets,
alex.williamson, sashal, dan.carpenter, linux-hyperv
From: Tianyu.Lan@microsoft.com <Tianyu.Lan@microsoft.com> Sent: Friday, February 22, 2019 4:12 AM
>
> On the bare metal, enabling X2APIC mode requires interrupt remapping
> function which helps to deliver irq to cpu with 32-bit APIC ID.
> Hyper-V doesn't provide interrupt remapping function so far and Hyper-V
> MSI protocol already supports to deliver interrupt to the CPU whose
> virtual processor index is more than 255. IO-APIC interrupt still has
> 8-bit APIC ID limitation.
>
> This patch is to add Hyper-V stub IOMMU driver in order to enable
> X2APIC mode successfully in Hyper-V Linux guest. The driver returns X2APIC
> interrupt remapping capability when X2APIC mode is available. Otherwise,
> it creates a Hyper-V irq domain to limit IO-APIC interrupts' affinity
> and make sure cpus assigned with IO-APIC interrupt have 8-bit APIC ID.
>
> Define 24 IO-APIC remapping entries because Hyper-V only expose one
> single IO-APIC and one IO-APIC has 24 pins according IO-APIC spec(
> https://pdos.csail.mit.edu/6.828/2016/readings/ia32/ioapic.pdf).
>
> Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
> ---
> Change since v4:
> - Fix the loop of scan cpu's APIC id
>
> Change since v3:
> - Make Hyper-V IOMMU as Hyper-V default driver
> - Fix hypervisor_is_type() input parameter
> - Check possible cpu numbers during scan 0~255 cpu's apic id.
>
> Change since v2:
> - Improve comment about why save IO-APIC entry in the irq chip data.
> - Some code improvement.
> - Improve statement in the IOMMU Kconfig.
>
> Change since v1:
> - Remove unused pr_fmt
> - Make ioapic_ir_domain as static variable
> - Remove unused variables cfg and entry in the hyperv_irq_remapping_alloc()
> - Fix comments
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH V5 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode
[not found] <1550837545-10760-1-git-send-email-Tianyu.Lan@microsoft.com>
[not found] ` <1550837545-10760-3-git-send-email-Tianyu.Lan@microsoft.com>
@ 2019-02-25 20:51 ` Michael Kelley
2019-02-26 11:01 ` joro
1 sibling, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2019-02-25 20:51 UTC (permalink / raw)
To: joro
Cc: Tianyu Lan, arnd, bp, davem, devel, gregkh, Haiyang Zhang, hpa,
iommu, KY Srinivasan, linux-kernel, mchehab+samsung, mingo,
nicolas.ferre, sashal, Stephen Hemminger, tglx, x86, vkuznets,
alex.williamson, dan.carpenter, linux-hyperv
From: Tianyu Lan <Tianyu.Lan@microsoft.com> Sent: Friday, February 22, 2019 4:12 AM
>
> On the bare metal, enabling X2APIC mode requires interrupt remapping
> function which helps to deliver irq to cpu with 32-bit APIC ID.
> Hyper-V doesn't provide interrupt remapping function so far and Hyper-V
> MSI protocol already supports to deliver interrupt to the CPU whose
> virtual processor index is more than 255. IO-APIC interrupt still has
> 8-bit APIC ID limitation.
>
> This patchset is to add Hyper-V stub IOMMU driver in order to enable
> X2APIC mode successfully in Hyper-V Linux guest. The driver returns X2APIC
> interrupt remapping capability when X2APIC mode is available. X2APIC
> destination mode is set to physical by PATCH 1 when X2APIC is available.
> Hyper-V IOMMU driver will scan cpu 0~255 and set cpu into IO-APIC MAX cpu
> affinity cpumask if its APIC ID is 8-bit. Driver creates a Hyper-V irq domain
> to limit IO-APIC interrupts' affinity and make sure cpus assigned with IO-APIC
> interrupt are in the scope of IO-APIC MAX cpu affinity.
>
> Lan Tianyu (3):
> x86/Hyper-V: Set x2apic destination mode to physical when x2apic is
> available
> HYPERV/IOMMU: Add Hyper-V stub IOMMU driver
> MAINTAINERS: Add Hyper-V IOMMU driver into Hyper-V CORE AND DRIVERS
> scope
>
Joerg -- What's your take on this patch set now that it has settled down? If
you are good with it, from the Microsoft standpoint we're hoping that it
can get into linux-next this week (given the extra week due to 5.0-rc8).
Thanks,
Michael Kelley
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V5 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode
2019-02-25 20:51 ` [PATCH V5 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode Michael Kelley
@ 2019-02-26 11:01 ` joro
0 siblings, 0 replies; 3+ messages in thread
From: joro @ 2019-02-26 11:01 UTC (permalink / raw)
To: Michael Kelley
Cc: Tianyu Lan, arnd, bp, davem, devel, gregkh, Haiyang Zhang, hpa,
iommu, KY Srinivasan, linux-kernel, mchehab+samsung, mingo,
nicolas.ferre, sashal, Stephen Hemminger, tglx, x86, vkuznets,
alex.williamson, dan.carpenter, linux-hyperv
On Mon, Feb 25, 2019 at 08:51:22PM +0000, Michael Kelley wrote:
> Joerg -- What's your take on this patch set now that it has settled down? If
> you are good with it, from the Microsoft standpoint we're hoping that it
> can get into linux-next this week (given the extra week due to 5.0-rc8).
I can't find v5 of the patch-set in my inbox or my iommu-list folder.
Please re-send to me with all Acks and Reviewed-by's added.
Thanks,
Joerg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-26 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1550837545-10760-1-git-send-email-Tianyu.Lan@microsoft.com>
[not found] ` <1550837545-10760-3-git-send-email-Tianyu.Lan@microsoft.com>
2019-02-22 15:58 ` [PATCH V5 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver Michael Kelley
2019-02-25 20:51 ` [PATCH V5 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode Michael Kelley
2019-02-26 11:01 ` joro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).