From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A27AC3A5A6 for ; Tue, 27 Aug 2019 23:56:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48D2D206BF for ; Tue, 27 Aug 2019 23:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=microsoft.com header.i=@microsoft.com header.b="oy62PZXr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726331AbfH0X4r (ORCPT ); Tue, 27 Aug 2019 19:56:47 -0400 Received: from mail-eopbgr740129.outbound.protection.outlook.com ([40.107.74.129]:38917 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725992AbfH0X4q (ORCPT ); Tue, 27 Aug 2019 19:56:46 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MOsBTmpSvehPcWLUpQpUo4M+Ac6/kggdyevHaW5ep+lIEDTM3LWt3YZN0+NErnOLa4lvjpxKaUsOF0G5BXHTx/0M8gH9bjJTtDsDYLmy9XpD6zdkEY/SIuIC0AwkG5QQdMeOy06OXi7tOAa/LxMQm+89vHzRMZaOtoEOEnfgS7VPnsekkECN2f6XRQ5LAP5FsjVyplRS4RIRxJKQ8TFzbzLGUq5ZPgPzYCDZjFhDaMVJVcIOrr6XlnrdKRfvm4CY9fx0OsKvvW/lu2WnZpqgLrNksxACR1QC4nB+G2s0bl6PxnbNwngfWrEXoi+Iqb+EFkJ3NZOF3IZJm7Z45397WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yvzJCJHATgCNAHmlGeR2AdXGvU9geZTTvSE6vCdIWU4=; b=WpefTjphmbk2Sg8VGIixolAfmZ2JHnZsXaF1F7wm2LgAMsgUXFst4SZ5wEVY/R1Xo5CbWszG2LS/SGZ7eWVSJm/RipQN8Z3iJgZX0twONC3NEVHa+I8fp3N/n39cGTAPRLvYTmKZnt6bDhCE4ep8tKEvkDI/ekZcjiI0ycgfl+s1aP+HfD/bhlq2f4kL7abdRJZl1ZrClBCflO5VHSG5cuXpvQO1CdEN/lmqcachd7hAoELnJyvAzfCS/t+GPSWcLZnO01zDV/pFtlmnnLRWjgJXGXF4wgTVRGFrMa+I1NM5MmCgrV4bjIwBncPFa4CInrgu8Q/6/TO/VEKxLw5Y1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yvzJCJHATgCNAHmlGeR2AdXGvU9geZTTvSE6vCdIWU4=; b=oy62PZXrzbFJdoDeSW/jrjxOtaFZ14XSJorz+cnF5x5vo6NyGIfPmLRPSzzGhIwwrGLII81BFLo15jZvCGUezL4bL/W177WRxlJu3h0qLel1A7IT/mS2GMu+XaRnsaHFP14epxiRWi3FpZV6yy7ob3cCVSFNEloZaVFXK0xLkQw= Received: from DM5PR21MB0137.namprd21.prod.outlook.com (10.173.173.12) by DM5PR21MB0859.namprd21.prod.outlook.com (10.173.172.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.1; Tue, 27 Aug 2019 23:56:43 +0000 Received: from DM5PR21MB0137.namprd21.prod.outlook.com ([fe80::c437:6219:efcc:fb8a]) by DM5PR21MB0137.namprd21.prod.outlook.com ([fe80::c437:6219:efcc:fb8a%7]) with mapi id 15.20.2241.000; Tue, 27 Aug 2019 23:56:43 +0000 From: Michael Kelley To: Wei Hu , "b.zolnierkie@samsung.com" , "linux-hyperv@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sashal@kernel.org" , Stephen Hemminger , Haiyang Zhang , KY Srinivasan , Dexuan Cui CC: Iouri Tarassov Subject: RE: [PATCH v3] video: hyperv: hyperv_fb: Obtain screen resolution from Hyper-V host Thread-Topic: [PATCH v3] video: hyperv: hyperv_fb: Obtain screen resolution from Hyper-V host Thread-Index: AQHVXMfGJ3Qba7Bfm06iN/QPH/c1OqcPqo/w Date: Tue, 27 Aug 2019 23:56:42 +0000 Message-ID: References: <20190827110755.2707-1-weh@microsoft.com> In-Reply-To: <20190827110755.2707-1-weh@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-08-27T23:56:41.1284187Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=22d3c610-3ee8-44bd-b8c5-5b9a2554642b; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=mikelley@microsoft.com; x-originating-ip: [2001:4898:80e8:7:d0b9:e2d7:362d:146a] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e846159-bf66-4493-6276-08d72b4a360a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DM5PR21MB0859; x-ms-traffictypediagnostic: DM5PR21MB0859:|DM5PR21MB0859: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0142F22657 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(189003)(199004)(54534003)(256004)(86362001)(2201001)(6636002)(8936002)(8676002)(305945005)(6116002)(8990500004)(74316002)(7736002)(10090500001)(2906002)(229853002)(76176011)(4326008)(7696005)(22452003)(186003)(102836004)(11346002)(476003)(446003)(486006)(71190400001)(46003)(71200400001)(110136005)(316002)(66556008)(14454004)(1511001)(5660300002)(6506007)(478600001)(6246003)(81156014)(9686003)(55016002)(76116006)(66446008)(64756008)(25786009)(52536014)(107886003)(53936002)(66476007)(6436002)(10290500003)(66946007)(2501003)(99286004)(33656002)(81166006)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR21MB0859;H:DM5PR21MB0137.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 2zVW5XWzfEFpYuoaMtpkAVKIUQqHdDwgqLvDb7/5WLackUgu/rvEEBsvtkcMIJ2vcWQ5Og3HGQNDfWEVvtGDcfpgLMhQYM6L1Kg/6snpMu7Vr0PVq5i8PAF0Fvpv808uFx+5r+hzb4Dt7nOuXTN5ty4LI9qK42pJFguZcZPHuoCDr8KKK9qiV8ui7YxT5ra9+O5ImxV6EQp4LTPi3rGai2xPobfLpbJ5cI4ax+xqpVS61YGwnNi/5vwlLOSqn80eXr6ZtRXLxUMmBIf+BvzVnfzsHiYivcx7NSU9GSk5ixxgNk7SIXnsFSDhT1hPhKERLJV7WlaW135iovm3yTPz1n/zoiaceyDuT6P1MhGxv1NkYGjmjOevK920SlAzflNS1MUoQ//ck5pNjUn3RHXPwrM4ZvqK1y3hHhK2LcORqP0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e846159-bf66-4493-6276-08d72b4a360a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2019 23:56:42.9089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CC6i1Q3hWnbBUoR0IFY4N8UGqp5EqHfn/fWdlmDlG2upq6Olvm5GZBBS7uJCmvsHNfJ/nzA/khnUP/QorO9JqaHczxai92lLL+V5VALVHYg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0859 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Hu Sent: Tuesday, August 27, 2019 4:09 AM >=20 > Beginning from Windows 10 RS5+, VM screen resolution is obtained from hos= t. > The "video=3Dhyperv_fb" boot time option is not needed, but still can be > used to overwrite what the host specifies. The VM resolution on the host > could be set by executing the powershell "set-vmvideo" command. >=20 > v2: > - Implemented fallback when version negotiation failed. > - Defined full size for supported_resolution array. >=20 > v3: > - Corrected the synthvid major and minor version comparison problem. The changelog for v2 and v3 should actually go after the "---" below so that the changelog does not end up as part of the commit message. Take a look at other postings to LKML for an example. >=20 > Signed-off-by: Iouri Tarassov > Signed-off-by: Wei Hu > --- > drivers/video/fbdev/hyperv_fb.c | 159 +++++++++++++++++++++++++++++--- > 1 file changed, 147 insertions(+), 12 deletions(-) >=20 >=20 > +/* Check if the ver1 version is equal or greater than ver2 */ > +static inline bool synthvid_ver_eg(u32 ver1, u32 ver2) I'm being picky here, but I would call this synthvid_ver_ge(). In my experience "ge" is the shorthand for "greater than or equal", rather than the "eg" you have used. Michael > +{ > + if (SYNTHVID_VER_GET_MAJOR(ver1) > SYNTHVID_VER_GET_MAJOR(ver2) || > + (SYNTHVID_VER_GET_MAJOR(ver1) =3D=3D SYNTHVID_VER_GET_MAJOR(ver2) &= & > + SYNTHVID_VER_GET_MINOR(ver1) >=3D SYNTHVID_VER_GET_MINOR(ver2))) > + return true; > + > + return false; > +}