From: Dragan Cvetic <draganc@xilinx.com>
To: John Hubbard <jhubbard@nvidia.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
Derek Kiernan <dkiernan@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michal Simek <michals@xilinx.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()
Date: Fri, 29 May 2020 08:29:09 +0000 [thread overview]
Message-ID: <DM6PR02MB41405A1300813F8A511BE449CB8F0@DM6PR02MB4140.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20200527012628.1100649-1-jhubbard@nvidia.com>
Hi John,
Thank you for the suggestion, please find my comment below:
> -----Original Message-----
> From: John Hubbard <jhubbard@nvidia.com>
> Sent: Wednesday 27 May 2020 02:26
> To: LKML <linux-kernel@vger.kernel.org>
> Cc: Souptick Joarder <jrdr.linux@gmail.com>; John Hubbard <jhubbard@nvidia.com>; Derek Kiernan <dkiernan@xilinx.com>; Dragan
> Cvetic <draganc@xilinx.com>; Arnd Bergmann <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek
> <michals@xilinx.com>; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()
>
> Hi,
>
> There are also a couple of tiny cleanup patches, just to fix up a few
> minor issues that I spotted while converting from get_user_pages_fast()
> to pin_user_pages_fast().
>
> Note that I have only compile-tested these patches, although that does
> also include cross-compiling for a few other arches. Any run-time
> testing would be greatly appreciated!
>
> Cc: Derek Kiernan <derek.kiernan@xilinx.com>
> Cc: Dragan Cvetic <dragan.cvetic@xilinx.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: linux-arm-kernel@lists.infradead.org
>
> John Hubbard (3):
> misc: xilinx-sdfec: improve get_user_pages_fast() error handling
> misc: xilinx-sdfec: cleanup return value in xsdfec_table_write()
> misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()
Reviewed-by:
Technically there is no problem in this patch, but as you said this should be tested.
Currently due to Covid-19 I'm not able to access the HW and I cannot validate this suggestion.
>
> drivers/misc/xilinx_sdfec.c | 30 +++++++++++++++++-------------
> 1 file changed, 17 insertions(+), 13 deletions(-)
>
>
> base-commit: 9cb1fd0efd195590b828b9b865421ad345a4a145
> --
> 2.26.2
next prev parent reply other threads:[~2020-05-29 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 1:26 [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() John Hubbard
2020-05-27 1:26 ` [PATCH 1/3] misc: xilinx-sdfec: improve get_user_pages_fast() error handling John Hubbard
2020-05-27 1:26 ` [PATCH 2/3] misc: xilinx-sdfec: cleanup return value in xsdfec_table_write() John Hubbard
2020-05-27 1:26 ` [PATCH 3/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() John Hubbard
2020-05-29 8:29 ` Dragan Cvetic [this message]
2020-05-29 19:15 ` [PATCH 0/3] " John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR02MB41405A1300813F8A511BE449CB8F0@DM6PR02MB4140.namprd02.prod.outlook.com \
--to=draganc@xilinx.com \
--cc=arnd@arndb.de \
--cc=dkiernan@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).