From: Srinivas Neeli <sneeli@xilinx.com>
To: Linus Walleij <linus.walleij@linaro.org>,
kernel test robot <lkp@intel.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Michal Simek <michals@xilinx.com>,
Shubhrajyoti Datta <shubhraj@xilinx.com>,
Srinivas Goud <sgoud@xilinx.com>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
git <git@xilinx.com>
Subject: RE: [PATCH V2 2/3] gpio: xilinx: Add interrupt support
Date: Fri, 24 Jul 2020 14:56:11 +0000 [thread overview]
Message-ID: <DM6PR02MB5386E88C8E3CA66987B452BFAF770@DM6PR02MB5386.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CACRpkda0YiUQTUDOEo7gnuegtPFauUyeLWs7wDkapzrUC-nwAw@mail.gmail.com>
Hi Linus,
Thanks for the review
> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: Friday, July 24, 2020 2:52 PM
> To: kernel test robot <lkp@intel.com>
> Cc: Srinivas Neeli <sneeli@xilinx.com>; Bartosz Golaszewski
> <bgolaszewski@baylibre.com>; Michal Simek <michals@xilinx.com>;
> Shubhrajyoti Datta <shubhraj@xilinx.com>; Srinivas Goud
> <sgoud@xilinx.com>; kbuild-all@lists.01.org; open list:GPIO SUBSYSTEM
> <linux-gpio@vger.kernel.org>; Linux ARM <linux-arm-
> kernel@lists.infradead.org>; linux-kernel@vger.kernel.org; git
> <git@xilinx.com>
> Subject: Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support
>
> On Fri, Jul 24, 2020 at 6:12 AM kernel test robot <lkp@intel.com> wrote:
>
> > drivers/gpio/gpio-xilinx.c: In function 'xgpio_probe':
> > drivers/gpio/gpio-xilinx.c:638:10: error: 'struct gpio_chip' has no member
> named 'of_gpio_n_cells'
> > 638 | chip->gc.of_gpio_n_cells = cells;
> > | ^
> > >> drivers/gpio/gpio-xilinx.c:639:10: error: 'struct gpio_chip' has no
> member named 'of_xlate'
> > 639 | chip->gc.of_xlate = xgpio_xlate;
> > | ^
>
> This is probably because your driver needs:
>
> depends on OF_GPIO
>
> in KConfig
>
I will address in v3.
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2020-07-24 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 14:06 [PATCH V2 0/3] gpio-xilinx: Update on xilinx gpio driver Srinivas Neeli
2020-07-23 14:06 ` [PATCH V2 1/3] gpio: xilinx: Add clock adaptation support Srinivas Neeli
2020-08-18 20:11 ` Bartosz Golaszewski
2020-07-23 14:06 ` [PATCH V2 2/3] gpio: xilinx: Add interrupt support Srinivas Neeli
2020-07-23 18:03 ` Andy Shevchenko
2020-07-24 17:15 ` Srinivas Neeli
2020-07-24 19:58 ` Andy Shevchenko
2020-07-24 21:02 ` Robert Hancock
2020-07-24 4:11 ` kernel test robot
2020-07-24 9:22 ` Linus Walleij
2020-07-24 14:56 ` Srinivas Neeli [this message]
2020-07-23 14:06 ` [PATCH V2 3/3] MAINTAINERS: add fragment for xilinx GPIO drivers Srinivas Neeli
2020-07-24 9:28 ` Michal Simek
2020-07-24 9:33 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR02MB5386E88C8E3CA66987B452BFAF770@DM6PR02MB5386.namprd02.prod.outlook.com \
--to=sneeli@xilinx.com \
--cc=bgolaszewski@baylibre.com \
--cc=git@xilinx.com \
--cc=kbuild-all@lists.01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michals@xilinx.com \
--cc=sgoud@xilinx.com \
--cc=shubhraj@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).