* [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
@ 2020-11-19 14:59 Alexandru Ardelean
2020-11-20 15:46 ` Greg KH
2020-11-23 14:34 ` [PATCH v2] " Alexandru Ardelean
0 siblings, 2 replies; 5+ messages in thread
From: Alexandru Ardelean @ 2020-11-19 14:59 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, Alexandru Ardelean
The pci_get_drvdata() was moved during commit ef84928cff58
("uio/uio_pci_generic: use device-managed function equivalents").
I should have notice that the pci_set_drvdata() requires a
pci_get_drvdata() for it to make sense.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
Apologies for not noticing this sooner.
If this can be squashed into commit ef84928cff58 , then it's also fine.
I've started seeing that there actually more xxx_set_drvdata() leftovers
in the entire kernel, and I pinged the checkpatch crew to add a check
for this.
https://lore.kernel.org/lkml/CA+U=Dspy5+RE9agcLr6eY9DCMa1c5+++0JLeugMMBRXz4YLj1w@mail.gmail.com/T/#u
drivers/uio/uio_pci_generic.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
index 1c6c09e1280d..b8e44d16279f 100644
--- a/drivers/uio/uio_pci_generic.c
+++ b/drivers/uio/uio_pci_generic.c
@@ -101,13 +101,7 @@ static int probe(struct pci_dev *pdev,
"no support for interrupts?\n");
}
- err = devm_uio_register_device(&pdev->dev, &gdev->info);
- if (err)
- return err;
-
- pci_set_drvdata(pdev, gdev);
-
- return 0;
+ return devm_uio_register_device(&pdev->dev, &gdev->info);
}
static struct pci_driver uio_pci_driver = {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
2020-11-19 14:59 [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() Alexandru Ardelean
@ 2020-11-20 15:46 ` Greg KH
2020-11-21 7:56 ` Ardelean, Alexandru
2020-11-23 14:34 ` [PATCH v2] " Alexandru Ardelean
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2020-11-20 15:46 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-kernel
On Thu, Nov 19, 2020 at 04:59:06PM +0200, Alexandru Ardelean wrote:
> The pci_get_drvdata() was moved during commit ef84928cff58
> ("uio/uio_pci_generic: use device-managed function equivalents").
>
> I should have notice that the pci_set_drvdata() requires a
> pci_get_drvdata() for it to make sense.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
>
> Apologies for not noticing this sooner.
> If this can be squashed into commit ef84928cff58 , then it's also fine.
> I've started seeing that there actually more xxx_set_drvdata() leftovers
> in the entire kernel, and I pinged the checkpatch crew to add a check
> for this.
>
> https://lore.kernel.org/lkml/CA+U=Dspy5+RE9agcLr6eY9DCMa1c5+++0JLeugMMBRXz4YLj1w@mail.gmail.com/T/#u
I can't squash existing public commits. Can you resend this and add a
"Fixes:" tag to it to show what commit it fixes so we can track this
properly?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
2020-11-20 15:46 ` Greg KH
@ 2020-11-21 7:56 ` Ardelean, Alexandru
0 siblings, 0 replies; 5+ messages in thread
From: Ardelean, Alexandru @ 2020-11-21 7:56 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Friday, November 20, 2020 5:46 PM
> To: Ardelean, Alexandru <alexandru.Ardelean@analog.com>
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
>
> [External]
>
> On Thu, Nov 19, 2020 at 04:59:06PM +0200, Alexandru Ardelean wrote:
> > The pci_get_drvdata() was moved during commit ef84928cff58
> > ("uio/uio_pci_generic: use device-managed function equivalents").
> >
> > I should have notice that the pci_set_drvdata() requires a
> > pci_get_drvdata() for it to make sense.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > ---
> >
> > Apologies for not noticing this sooner.
> > If this can be squashed into commit ef84928cff58 , then it's also fine.
> > I've started seeing that there actually more xxx_set_drvdata()
> > leftovers in the entire kernel, and I pinged the checkpatch crew to
> > add a check for this.
> >
> > https://urldefense.com/v3/__https://lore.kernel.org/lkml/CA*U=Dspy5*RE
> >
> 9agcLr6eY9DCMa1c5**B0JLeugMMBRXz4YLj1w@mail.gmail.com/T/*u__;KysrK
> ysj!
> >
> !A3Ni8CS0y2Y!q3fJW4rKvEHQ7BDt1PaK4Cbexv4wbivUKBeDjo7ZwNXYwOLBawA
> Eq1Jaj
> > mhYxftX6DAJpg$
>
> I can't squash existing public commits. Can you resend this and add a "Fixes:"
> tag to it to show what commit it fixes so we can track this properly?
>
Sure, will re-send in the next couple of days.
Thanks
Alex
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
2020-11-19 14:59 [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() Alexandru Ardelean
2020-11-20 15:46 ` Greg KH
@ 2020-11-23 14:34 ` Alexandru Ardelean
2020-11-24 6:59 ` Ardelean, Alexandru
1 sibling, 1 reply; 5+ messages in thread
From: Alexandru Ardelean @ 2020-11-23 14:34 UTC (permalink / raw)
To: linux-kernel, kvm; +Cc: mst, gregkh, Alexandru Ardelean
The pci_get_drvdata() was moved during commit ef84928cff58
("uio/uio_pci_generic: use device-managed function equivalents").
Storing a private object with pci_set_drvdata() doesn't make sense
since that change, since there is no more pci_get_drvdata() call in the
driver to retrieve the information.
This change removes it.
Fixes: ef84928cff58 ("io/uio_pci_generic: use device-managed function equivalents")
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/uio/uio_pci_generic.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
index 1c6c09e1280d..b8e44d16279f 100644
--- a/drivers/uio/uio_pci_generic.c
+++ b/drivers/uio/uio_pci_generic.c
@@ -101,13 +101,7 @@ static int probe(struct pci_dev *pdev,
"no support for interrupts?\n");
}
- err = devm_uio_register_device(&pdev->dev, &gdev->info);
- if (err)
- return err;
-
- pci_set_drvdata(pdev, gdev);
-
- return 0;
+ return devm_uio_register_device(&pdev->dev, &gdev->info);
}
static struct pci_driver uio_pci_driver = {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH v2] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
2020-11-23 14:34 ` [PATCH v2] " Alexandru Ardelean
@ 2020-11-24 6:59 ` Ardelean, Alexandru
0 siblings, 0 replies; 5+ messages in thread
From: Ardelean, Alexandru @ 2020-11-24 6:59 UTC (permalink / raw)
To: Ardelean, Alexandru, linux-kernel, kvm; +Cc: mst, gregkh
> -----Original Message-----
> From: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Sent: Monday, November 23, 2020 4:35 PM
> To: linux-kernel@vger.kernel.org; kvm@vger.kernel.org
> Cc: mst@redhat.com; gregkh@linuxfoundation.org; Ardelean, Alexandru
> <alexandru.Ardelean@analog.com>
> Subject: [PATCH v2] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
>
> The pci_get_drvdata() was moved during commit ef84928cff58
> ("uio/uio_pci_generic: use device-managed function equivalents").
>
> Storing a private object with pci_set_drvdata() doesn't make sense since that
> change, since there is no more pci_get_drvdata() call in the driver to retrieve the
> information.
>
> This change removes it.
>
> Fixes: ef84928cff58 ("io/uio_pci_generic: use device-managed function
> equivalents")
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
Forgot the changelog
Apologies.
Changelog v1 -> v2:
* added Fixes tag
* updated commit comment a bit from V1
> drivers/uio/uio_pci_generic.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c index
> 1c6c09e1280d..b8e44d16279f 100644
> --- a/drivers/uio/uio_pci_generic.c
> +++ b/drivers/uio/uio_pci_generic.c
> @@ -101,13 +101,7 @@ static int probe(struct pci_dev *pdev,
> "no support for interrupts?\n");
> }
>
> - err = devm_uio_register_device(&pdev->dev, &gdev->info);
> - if (err)
> - return err;
> -
> - pci_set_drvdata(pdev, gdev);
> -
> - return 0;
> + return devm_uio_register_device(&pdev->dev, &gdev->info);
> }
>
> static struct pci_driver uio_pci_driver = {
> --
> 2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-24 6:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 14:59 [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() Alexandru Ardelean
2020-11-20 15:46 ` Greg KH
2020-11-21 7:56 ` Ardelean, Alexandru
2020-11-23 14:34 ` [PATCH v2] " Alexandru Ardelean
2020-11-24 6:59 ` Ardelean, Alexandru
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).