From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Amy Parker <enbyamy@gmail.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] fs/efs: Use correct brace styling for statements
Date: Fri, 5 Feb 2021 04:57:08 +0000 [thread overview]
Message-ID: <DM6PR04MB4972E287DED6DA5D4435986286B29@DM6PR04MB4972.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210205045217.552927-2-enbyamy@gmail.com
On 2/4/21 20:55, Amy Parker wrote:
> Many single-line statements have unnecessary braces, and some statement pairs have mismatched braces. This is a clear violation of the kernel style guide, which mandates that single line statements have no braces and that pairs with at least one multi-line block maintain their braces.
>
> This patch fixes these style violations. Single-line statements that have braces have had their braces stripped. Pair single-line statements have been formatted per the style guide. Pair mixed-line statements have had their braces updated to conform.
>
> Signed-off-by: Amy Parker <enbyamy@gmail.com>
Commit message is too long. Follow the style present in the tree.
next prev parent reply other threads:[~2021-02-05 4:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 4:52 [PATCH 0/3] fs/efs: Follow kernel style guide Amy Parker
2021-02-05 4:52 ` [PATCH 1/3] fs/efs: Use correct brace styling for statements Amy Parker
2021-02-05 4:57 ` Chaitanya Kulkarni [this message]
2021-02-05 5:00 ` Amy Parker
2021-02-05 5:09 ` Chaitanya Kulkarni
2021-02-05 5:12 ` Amy Parker
2021-02-05 4:52 ` [PATCH 2/3] fs/efs: Correct spacing after C keywords Amy Parker
2021-02-05 4:52 ` [PATCH 3/3] fs/efs: Fix line breakage for " Amy Parker
2021-02-05 13:19 ` [PATCH 0/3] fs/efs: Follow kernel style guide David Sterba
2021-02-05 15:36 ` Amy Parker
2021-02-05 22:37 ` Richard Weinberger
2021-02-05 22:49 ` Amy Parker
2021-02-08 0:15 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB4972E287DED6DA5D4435986286B29@DM6PR04MB4972.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=enbyamy@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).