From: Avri Altman <Avri.Altman@wdc.com>
To: Can Guo <cang@codeaurora.org>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
Daejun Park <daejun7.park@samsung.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <Avi.Shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: RE: [PATCH v5 05/10] scsi: ufshpb: Region inactivation in host mode
Date: Tue, 16 Mar 2021 08:30:06 +0000 [thread overview]
Message-ID: <DM6PR04MB65751EE32D25C7E57A6BABE8FC6B9@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <57afb2b5d7edda61a40493d8545785b1@codeaurora.org>
> >> ---
> >> drivers/scsi/ufs/ufshpb.c | 14 ++++++++++++++
> >> drivers/scsi/ufs/ufshpb.h | 1 +
> >> 2 files changed, 15 insertions(+)
> >>
> >> diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> >> index 6f4fd22eaf2f..0744feb4d484 100644
> >> --- a/drivers/scsi/ufs/ufshpb.c
> >> +++ b/drivers/scsi/ufs/ufshpb.c
> >> @@ -907,6 +907,7 @@ static int ufshpb_execute_umap_req(struct
> >> ufshpb_lu *hpb,
> >>
> >> blk_execute_rq_nowait(q, NULL, req, 1, ufshpb_umap_req_compl_fn);
> >>
> >> + hpb->stats.umap_req_cnt++;
> >> return 0;
> >> }
> >>
> >> @@ -1103,6 +1104,12 @@ static int ufshpb_issue_umap_req(struct
> >> ufshpb_lu *hpb,
> >> return -EAGAIN;
> >> }
> >>
> >> +static int ufshpb_issue_umap_single_req(struct ufshpb_lu *hpb,
> >> + struct ufshpb_region *rgn)
> >> +{
> >> + return ufshpb_issue_umap_req(hpb, rgn);
> >> +}
> >> +
> >> static int ufshpb_issue_umap_all_req(struct ufshpb_lu *hpb)
> >> {
> >> return ufshpb_issue_umap_req(hpb, NULL);
> >> @@ -1115,6 +1122,10 @@ static void __ufshpb_evict_region(struct
> >> ufshpb_lu *hpb,
> >> struct ufshpb_subregion *srgn;
> >> int srgn_idx;
> >>
> >> +
> >> + if (hpb->is_hcm && ufshpb_issue_umap_single_req(hpb, rgn))
> >
> > __ufshpb_evict_region() is called with rgn_state_lock held and IRQ
> > disabled,
> > when ufshpb_issue_umap_single_req() invokes blk_execute_rq_nowait(),
> > below
> > warning shall pop up every time, fix it?
> >
> > void blk_execute_rq_nowait(struct request_queue *q, struct gendisk
> > *bd_disk,
> > struct request *rq, int at_head,
> > rq_end_io_fn *done)
> > {
> > WARN_ON(irqs_disabled());
> > ...
> >
>
> Moreover, since we are here with rgn_state_lock held and IRQ disabled,
> in ufshpb_get_req(), rq = kmem_cache_alloc(hpb->map_req_cache,
> GFP_KERNEL)
> has the GFP_KERNEL flag, scheduling while atomic???
I think your comment applies to ufshpb_issue_umap_all_req as well,
Which is called from slave_configure/scsi_add_lun.
Since the host-mode series is utilizing the framework laid by the device-mode,
Maybe you can add this comment to Daejun's last version?
Thanks,
Avri
>
> Can Guo.
>
> > Thanks.
> > Can Guo.
> >
> >> + return;
> >> +
> >> lru_info = &hpb->lru_info;
> >>
> >> dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "evict region %d\n",
> >> rgn->rgn_idx);
> >> @@ -1855,6 +1866,7 @@ ufshpb_sysfs_attr_show_func(rb_noti_cnt);
> >> ufshpb_sysfs_attr_show_func(rb_active_cnt);
> >> ufshpb_sysfs_attr_show_func(rb_inactive_cnt);
> >> ufshpb_sysfs_attr_show_func(map_req_cnt);
> >> +ufshpb_sysfs_attr_show_func(umap_req_cnt);
> >>
> >> static struct attribute *hpb_dev_stat_attrs[] = {
> >> &dev_attr_hit_cnt.attr,
> >> @@ -1863,6 +1875,7 @@ static struct attribute *hpb_dev_stat_attrs[] =
> >> {
> >> &dev_attr_rb_active_cnt.attr,
> >> &dev_attr_rb_inactive_cnt.attr,
> >> &dev_attr_map_req_cnt.attr,
> >> + &dev_attr_umap_req_cnt.attr,
> >> NULL,
> >> };
> >>
> >> @@ -1978,6 +1991,7 @@ static void ufshpb_stat_init(struct ufshpb_lu
> >> *hpb)
> >> hpb->stats.rb_active_cnt = 0;
> >> hpb->stats.rb_inactive_cnt = 0;
> >> hpb->stats.map_req_cnt = 0;
> >> + hpb->stats.umap_req_cnt = 0;
> >> }
> >>
> >> static void ufshpb_param_init(struct ufshpb_lu *hpb)
> >> diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
> >> index bd4308010466..84598a317897 100644
> >> --- a/drivers/scsi/ufs/ufshpb.h
> >> +++ b/drivers/scsi/ufs/ufshpb.h
> >> @@ -186,6 +186,7 @@ struct ufshpb_stats {
> >> u64 rb_inactive_cnt;
> >> u64 map_req_cnt;
> >> u64 pre_req_cnt;
> >> + u64 umap_req_cnt;
> >> };
> >>
> >> struct ufshpb_lu {
next prev parent reply other threads:[~2021-03-16 8:31 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 13:24 [PATCH v5 00/10] Add Host control mode to HPB Avri Altman
2021-03-02 13:24 ` [PATCH v5 01/10] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-03-02 13:24 ` [PATCH v5 02/10] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-03-02 13:24 ` [PATCH v5 03/10] scsi: ufshpb: Add region's reads counter Avri Altman
2021-03-11 7:52 ` Can Guo
2021-03-11 8:04 ` Avri Altman
2021-03-11 8:07 ` Can Guo
2021-03-15 3:16 ` Can Guo
2021-03-15 9:20 ` Avri Altman
2021-03-15 9:31 ` Can Guo
2021-03-17 9:19 ` Avri Altman
2021-03-15 8:40 ` Can Guo
2021-03-15 9:22 ` Avri Altman
2021-03-02 13:24 ` [PATCH v5 04/10] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-03-11 7:53 ` Can Guo
2021-03-11 8:06 ` Avri Altman
2021-03-15 8:30 ` Can Guo
2021-03-16 8:34 ` Avri Altman
2021-03-02 13:24 ` [PATCH v5 05/10] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-03-11 8:20 ` Can Guo
2021-03-11 9:03 ` Avri Altman
2021-03-15 4:02 ` Can Guo
2021-03-15 7:33 ` Can Guo
2021-03-16 8:30 ` Avri Altman [this message]
2021-03-17 1:23 ` Can Guo
[not found] ` <CGME20210316083014epcas2p32d6b84e689cdbe06ee065c870b236d65@epcms2p3>
2021-03-17 2:28 ` Daejun Park
2021-03-17 4:41 ` Can Guo
2021-03-17 7:59 ` Avri Altman
[not found] ` <CGME20210316083014epcas2p32d6b84e689cdbe06ee065c870b236d65@epcms2p4>
2021-03-17 5:19 ` Daejun Park
2021-03-17 5:34 ` Can Guo
[not found] ` <CGME20210316083014epcas2p32d6b84e689cdbe06ee065c870b236d65@epcms2p6>
2021-03-17 5:42 ` Daejun Park
2021-03-02 13:24 ` [PATCH v5 06/10] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-03-15 1:34 ` Can Guo
2021-03-15 6:40 ` Can Guo
2021-03-15 7:42 ` Avri Altman
2021-03-17 10:56 ` Can Guo
2021-03-17 11:23 ` Avri Altman
2021-03-17 12:12 ` Can Guo
2021-03-17 12:22 ` Avri Altman
2021-03-17 13:50 ` Can Guo
2021-03-17 14:22 ` Avri Altman
2021-03-17 14:36 ` Can Guo
2021-03-17 15:46 ` Avri Altman
2021-03-18 1:00 ` Can Guo
2021-03-18 8:04 ` Avri Altman
2021-03-02 13:25 ` [PATCH v5 07/10] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-03-15 1:37 ` Can Guo
2021-03-15 7:54 ` Avri Altman
2021-03-15 9:36 ` Can Guo
2021-03-16 9:21 ` Avri Altman
2021-03-17 2:45 ` Can Guo
2021-03-17 7:55 ` Avri Altman
2021-06-01 16:22 ` Bart Van Assche
2021-03-02 13:25 ` [PATCH v5 08/10] scsi: ufshpb: Limit the number of inflight map requests Avri Altman
2021-03-15 8:31 ` Can Guo
2021-03-16 8:32 ` Avri Altman
2021-03-02 13:25 ` [PATCH v5 09/10] scsi: ufshpb: Add support for host control mode Avri Altman
2021-03-02 13:25 ` [PATCH v5 10/10] scsi: ufshpb: Make host mode parameters configurable Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB65751EE32D25C7E57A6BABE8FC6B9@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=Avi.Shchislowski@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).