From: Avri Altman <Avri.Altman@wdc.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brendan Peter <bpeter@lytx.com>
Subject: RE: [PATCH v2 1/2] mmc: block: Issue flush only if allowed
Date: Mon, 19 Apr 2021 12:47:20 +0000 [thread overview]
Message-ID: <DM6PR04MB6575351DBFF56CF453D7BB8AFC499@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <CAPDyKFqAdXcVO9=26pTbQyzYprax9-_i0T1XMeXTWAYOMAaovw@mail.gmail.com>
>
> On Sun, 18 Apr 2021 at 08:00, Avri Altman <avri.altman@wdc.com> wrote:
> >
> > The cache may be flushed to the nonvolatile storage by writing to
> > FLUSH_CACHE byte (EXT_CSD byte [32]). When in command queueing mode,
> the
> > cache may be flushed by issuing a CMDQ_TASK_ DEV_MGMT (CMD48) with a
> > FLUSH_CACHE op-code. Either way, verify that The cache function is
> > turned ON before doing so.
>
> Avri, thanks for your patch. Overall this looks good to me.
>
> However things are becoming more and more messy in these layers of the
> mmc core. In particular, I would like us to take advantage of the
> bus_ops callbacks, when eMMC and/or SD specific features need
> different implementations.
>
> I have posted a patch [1], that moves the eMMC cache flushing into a
> bus_ops callback. Would you mind rebasing this series on top of that?
Sure.
Thanks,
Avri
>
> Kind regards
> Uffe
>
> [1]
> https://patchwork.kernel.org/project/linux-
> mmc/patch/20210419122943.68234-1-ulf.hansson@linaro.org/
next prev parent reply other threads:[~2021-04-19 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 5:59 [PATCH v2 0/2] Do not flush cache when it is disabled Avri Altman
2021-04-18 5:59 ` [PATCH v2 1/2] mmc: block: Issue flush only if allowed Avri Altman
2021-04-19 12:39 ` Ulf Hansson
2021-04-19 12:47 ` Avri Altman [this message]
2021-04-19 12:48 ` Avri Altman
2021-04-18 5:59 ` [PATCH v2 2/2] mmc: block: Update ext_csd.cache_ctrl if it was written Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB6575351DBFF56CF453D7BB8AFC499@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=bpeter@lytx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).