linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Bart Van Assche <bvanassche@acm.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Bean Huo <beanhuo@micron.com>
Subject: RE: [PATCH v2 2/2] scsi: ufs: Add temperature notification exception handling
Date: Fri, 10 Sep 2021 16:32:20 +0000	[thread overview]
Message-ID: <DM6PR04MB657584129D49F3C90CA0C462FCD69@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20210909165431.GB3973437@roeck-us.net>

> > +static void ufshcd_temp_exception_event_handler(struct ufs_hba *hba,
> > +u16 status) {
> > +     u32 value;
> > +
> > +     if (ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> > +                           QUERY_ATTR_IDN_CASE_ROUGH_TEMP, 0, 0, &value))
> > +             return;
> > +
> > +     dev_info(hba->dev, "exception Tcase %d\n", value - 80);
> > +
> 
> It would probably make sense to call hwmon_notify_event() here.
Yes.  Thank you.

Thanks,
Avri

> 
> Guenter
> 
> > +     /*
> > +      * A placeholder for the platform vendors to add whatever additional
> > +      * steps required
> > +      */
> > +}
> > +
> >  static int __ufshcd_wb_toggle(struct ufs_hba *hba, bool set, enum
> > flag_idn idn)  {
> >       u8 index;
> > @@ -5821,6 +5837,9 @@ static void
> ufshcd_exception_event_handler(struct work_struct *work)
> >       if (status & hba->ee_drv_mask & MASK_EE_URGENT_BKOPS)
> >               ufshcd_bkops_exception_event_handler(hba);
> >
> > +     if (status & hba->ee_drv_mask & MASK_EE_URGENT_TEMP)
> > +             ufshcd_temp_exception_event_handler(hba, status);
> > +
> >       ufs_debugfs_exception_event(hba, status);
> >  out:
> >       ufshcd_scsi_unblock_requests(hba);
> > --
> > 2.17.1
> >

      reply	other threads:[~2021-09-10 16:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  6:34 [PATCH v2 0/2] Add temperature notification support Avri Altman
2021-09-09  6:34 ` [PATCH v2 1/2] scsi: ufs: Probe for " Avri Altman
2021-09-09 16:26   ` Bart Van Assche
2021-09-10 15:58     ` Avri Altman
2021-09-09 16:51   ` Guenter Roeck
2021-09-10 16:13     ` Avri Altman
2021-09-09  6:34 ` [PATCH v2 2/2] scsi: ufs: Add temperature notification exception handling Avri Altman
2021-09-09 16:54   ` Guenter Roeck
2021-09-10 16:32     ` Avri Altman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB657584129D49F3C90CA0C462FCD69@DM6PR04MB6575.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=adrian.hunter@intel.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).