From: Avri Altman <Avri.Altman@wdc.com>
To: Bean Huo <huobean@gmail.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "beanhuo@micron.com" <beanhuo@micron.com>
Subject: RE: [PATCH v1 2/2] mmc-utils: Add note for CMDQ_MODE_EN runtime value
Date: Mon, 15 Nov 2021 09:07:26 +0000 [thread overview]
Message-ID: <DM6PR04MB6575C2BC1385ACE6E41BAD8EFC989@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20211114204331.39555-3-huobean@gmail.com>
> From: Bean Huo <beanhuo@micron.com>
>
> Since the Linux kernel commit 70b52f090805 ("mmc: block: Disable CMDQ on
> the ioctl path"), CMDQ in CMDQ_MODE_EN[15] is disabled before reading
> EXT_CSD.
> Therefore, it is more accurate to use sysfs node to check CMDQ_MODE_EN
> value.
> Add a note print to highlight.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Acked-by: Avri Altman <avri.altman@wdc.com>
> ---
> mmc_cmds.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mmc_cmds.c b/mmc_cmds.c
> index ecbde3937c81..46c5f5faae02 100644
> --- a/mmc_cmds.c
> +++ b/mmc_cmds.c
> @@ -1885,6 +1885,8 @@ int do_read_extcsd(int nargs, char **argv)
> (ext_csd[EXT_CSD_CMDQ_DEPTH] & 0x1f) + 1);
> printf("Command Enabled [CMDQ_MODE_EN]: 0x%02x\n",
> ext_csd[EXT_CSD_CMDQ_MODE_EN]);
> + printf("Note: CMDQ_MODE_EN may not indicate the runtime
> CMDQ ON or OFF.\n"
> + "Please check sysfs node
> + '/sys/devices/.../mmc_host/mmcX/mmcX:XXXX/cmdq_en'\n");
> }
> out_free:
> return ret;
> --
> 2.25.1
next prev parent reply other threads:[~2021-11-15 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 20:43 [PATCH v1 0/2] Two change for mmc-utils Bean Huo
2021-11-14 20:43 ` [PATCH v1 1/2] mmc-utils: Use memcpy instead of strncpy Bean Huo
2021-11-15 7:09 ` Ajay Garg
2021-11-15 10:49 ` Bean Huo
2021-11-15 11:37 ` Ajay Garg
2021-11-15 8:38 ` Avri Altman
2021-11-14 20:43 ` [PATCH v1 2/2] mmc-utils: Add note for CMDQ_MODE_EN runtime value Bean Huo
2021-11-15 9:07 ` Avri Altman [this message]
2021-11-15 15:08 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB6575C2BC1385ACE6E41BAD8EFC989@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=beanhuo@micron.com \
--cc=huobean@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).