From: Avri Altman <Avri.Altman@wdc.com>
To: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
Greg KH <gregkh@linuxfoundation.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"huobean@gmail.com" <huobean@gmail.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
JinHwan Park <jh.i.park@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>,
SEUNGUK SHIN <seunguk.shin@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
BoRam Shin <boram.shin@samsung.com>
Subject: RE: [PATCH v29 4/4] scsi: ufs: Add HPB 2.0 support
Date: Sun, 21 Mar 2021 10:05:59 +0000 [thread overview]
Message-ID: <DM6PR04MB6575DEC175CD1D3895F1AF2BFC669@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20210315013137epcms2p861f06e66be9faff32b6648401778434a@epcms2p8>
> +static int ufshpb_execute_umap_req(struct ufshpb_lu *hpb,
> + struct ufshpb_req *umap_req,
> + struct ufshpb_region *rgn)
> +{
> + struct request *req;
> + struct scsi_request *rq;
> +
> + req = umap_req->req;
> + req->timeout = 0;
> + req->end_io_data = (void *)umap_req;
> + rq = scsi_req(req);
> + ufshpb_set_unmap_cmd(rq->cmd, rgn);
> + rq->cmd_len = HPB_WRITE_BUFFER_CMD_LENGTH;
> +
> + blk_execute_rq_nowait(NULL, req, 1, ufshpb_umap_req_compl_fn);
Typo? Forgot the struct request_queue *q?
> +
> + return 0;
> +}
> +
> static int ufshpb_execute_map_req(struct ufshpb_lu *hpb,
> struct ufshpb_req *map_req, bool last)
> {
> @@ -533,12 +878,12 @@ static int ufshpb_execute_map_req(struct ufshpb_lu
> *hpb,
>
> q = hpb->sdev_ufs_lu->request_queue;
> for (i = 0; i < hpb->pages_per_srgn; i++) {
> - ret = bio_add_pc_page(q, map_req->bio, map_req->mctx->m_page[i],
> + ret = bio_add_pc_page(q, map_req->bio, map_req->rb.mctx-
> >m_page[i],
> PAGE_SIZE, 0);
> if (ret != PAGE_SIZE) {
> dev_err(&hpb->sdev_ufs_lu->sdev_dev,
> "bio_add_pc_page fail %d - %d\n",
> - map_req->rgn_idx, map_req->srgn_idx);
> + map_req->rb.rgn_idx, map_req->rb.srgn_idx);
> return ret;
> }
> }
> @@ -554,8 +899,8 @@ static int ufshpb_execute_map_req(struct ufshpb_lu
> *hpb,
> if (unlikely(last))
> mem_size = hpb->last_srgn_entries * HPB_ENTRY_SIZE;
>
> - ufshpb_set_read_buf_cmd(rq->cmd, map_req->rgn_idx,
> - map_req->srgn_idx, mem_size);
> + ufshpb_set_read_buf_cmd(rq->cmd, map_req->rb.rgn_idx,
> + map_req->rb.srgn_idx, mem_size);
> rq->cmd_len = HPB_READ_BUFFER_CMD_LENGTH;
>
> blk_execute_rq_nowait(NULL, req, 1, ufshpb_map_req_compl_fn);
Ditto
Thanks,
Avri
next prev parent reply other threads:[~2021-03-21 10:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210315012850epcms2p361447b689e925561c48aa9ca54434eb5@epcms2p3>
2021-03-15 1:28 ` [PATCH v29 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20210315012850epcms2p361447b689e925561c48aa9ca54434eb5@epcms2p4>
2021-03-15 1:29 ` [PATCH v29 1/4] scsi: ufs: Introduce HPB feature Daejun Park
2021-03-15 1:30 ` [PATCH v29 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
[not found] ` <CGME20210315012850epcms2p361447b689e925561c48aa9ca54434eb5@epcms2p5>
2021-03-15 1:30 ` [PATCH v29 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
[not found] ` <CGME20210315012850epcms2p361447b689e925561c48aa9ca54434eb5@epcms2p8>
2021-03-15 1:31 ` [PATCH v29 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-03-15 5:05 ` Can Guo
2021-03-15 6:36 ` Can Guo
2021-03-21 10:05 ` Avri Altman [this message]
2021-03-15 7:07 ` Daejun Park
2021-03-15 7:23 ` Can Guo
2021-03-15 7:47 ` Can Guo
[not found] ` <CGME20210315012850epcms2p361447b689e925561c48aa9ca54434eb5@epcms2p1>
2021-03-17 1:42 ` Daejun Park
2021-03-17 2:45 ` Can Guo
2021-03-18 7:13 ` Daejun Park
2021-03-22 0:50 ` Daejun Park
2021-03-18 2:02 ` Daejun Park
2021-03-18 2:25 ` Can Guo
2021-03-18 4:49 ` Can Guo
2021-03-18 2:29 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB6575DEC175CD1D3895F1AF2BFC669@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=boram.shin@samsung.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=huobean@gmail.com \
--cc=j-young.choi@samsung.com \
--cc=javier.gonz@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=jh.i.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=seunguk.shin@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).