From: Avri Altman <Avri.Altman@wdc.com>
To: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
Greg KH <gregkh@linuxfoundation.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"huobean@gmail.com" <huobean@gmail.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
JinHwan Park <jh.i.park@samsung.com>,
SEUNGUK SHIN <seunguk.shin@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
yongmyung lee <ymhungry.lee@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
BoRam Shin <boram.shin@samsung.com>
Subject: RE: RE: [PATCH v22 3/4] scsi: ufs: Prepare HPB read for cached sub-region
Date: Tue, 23 Feb 2021 09:07:22 +0000 [thread overview]
Message-ID: <DM6PR04MB6575F87694FB14ECF068F681FC809@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20210223084327epcms2p5b158fa6769d3deee54796b364f0ae369@epcms2p5>
>
>
> > > + err = ufshpb_fill_ppn_from_page(hpb, srgn->mctx, srgn_offset, 1,
> &ppn);
> > > + spin_unlock_irqrestore(&hpb->rgn_state_lock, flags);
> > > + if (unlikely(err < 0)) {
> > > + /*
> > > + * In this case, the region state is active,
> > > + * but the ppn table is not allocated.
> > > + * Make sure that ppn table must be allocated on
> > > + * active state.
> > > + */
> > > + WARN_ON(true);
> > > + dev_err(hba->dev, "get ppn failed. err %d\n", err);
> > Maybe just pr_warn instead of risking crashing the machine over that?
>
> Why it crashing the machine? WARN_ON will just print kernel message.
I think that it can be configured, but I am not sure.
>
> Thanks,
> Daejun
next prev parent reply other threads:[~2021-02-23 9:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p3>
2021-02-22 9:29 ` [PATCH v22 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p8>
2021-02-22 9:31 ` [PATCH v22 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2021-02-23 8:27 ` Avri Altman
2021-02-23 13:49 ` Avri Altman
[not found] ` <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p5>
2021-02-23 8:43 ` Daejun Park
2021-02-23 9:07 ` Avri Altman [this message]
2021-02-23 9:24 ` Avri Altman
2021-02-23 9:49 ` Re: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-02-25 2:50 ` Daejun Park
2021-02-23 8:00 ` RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-02-23 8:31 ` Daejun Park
2021-02-23 8:46 ` Avri Altman
2021-02-23 9:51 ` RE: RE: [PATCH v22 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
[not found] ` <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p6>
2021-02-22 9:30 ` [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-02-23 7:50 ` Avri Altman
2021-02-23 7:54 ` Avri Altman
[not found] ` <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p4>
2021-02-23 8:01 ` Daejun Park
2021-02-23 8:04 ` RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-02-23 8:02 ` Daejun Park
2021-02-23 23:54 ` Daejun Park
2021-02-24 8:20 ` Avri Altman
2021-02-24 9:06 ` Avri Altman
[not found] ` <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p1>
2021-02-22 9:31 ` Daejun Park
2021-02-22 11:57 ` Bean Huo
2021-02-22 19:29 ` Avri Altman
2021-02-23 9:25 ` Bean Huo
2021-02-23 12:46 ` Avri Altman
2021-02-24 8:11 ` Avri Altman
2021-02-23 23:38 ` RE: [PATCH v22 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
[not found] ` <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p7>
2021-02-22 9:29 ` [PATCH v22 1/4] scsi: ufs: Introduce HPB feature Daejun Park
2021-02-25 2:42 ` RE: RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-02-25 7:51 ` Avri Altman
2021-02-23 8:55 ` RE: RE: RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB6575F87694FB14ECF068F681FC809@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=boram.shin@samsung.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=huobean@gmail.com \
--cc=j-young.choi@samsung.com \
--cc=javier.gonz@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=jh.i.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=seunguk.shin@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
--cc=ymhungry.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).