linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pawel Laszczak <pawell@cadence.com>
To: Peter Chen <peter.chen@nxp.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"balbi@kernel.org" <balbi@kernel.org>,
	"colin.king@canonical.com" <colin.king@canonical.com>,
	"rogerq@ti.com" <rogerq@ti.com>,
	Rahul Kumar <kurahul@cadence.com>,
	"nsekhar@ti.com" <nsekhar@ti.com>
Subject: RE: [PATCH v3 00/10] Introduced new Cadence USBSSP DRD Driver.
Date: Wed, 25 Nov 2020 06:07:45 +0000	[thread overview]
Message-ID: <DM6PR07MB55294D86FE79E85F41838918DDFA0@DM6PR07MB5529.namprd07.prod.outlook.com> (raw)
In-Reply-To: <DM6PR07MB55299F262CEA81216999CB05DDFB0@DM6PR07MB5529.namprd07.prod.outlook.com>

Peter,

>
>>On 20-11-19 15:12:57, Pawel Laszczak wrote:
>>> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>>
>>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>>> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
>>> Host Only (XHCI)configurations.
>>>
>>> The current driver has been validated with FPGA burned. We have support
>>> for PCIe bus, which is used on FPGA prototyping.
>>>
>>> The host side of USBSS-DRD controller is compliance with XHCI
>>> specification, so it works with standard XHCI Linux driver.
>>>
>>> The device side of USBSS DRD controller is compliant with XHCI.
>>> The architecture for device side is almost the same as for host side,
>>> and most of the XHCI specification can be used to understand how
>>> this controller operates.
>>>
>>> This controller and driver support Full Speed, Hight Speed, Supper Speed
>>> and Supper Speed Plus USB protocol.
>>>
>>> The prefix cdnsp used in driver has chosen by analogy to cdn3 driver.
>>> The last letter of this acronym means PLUS. The formal name of controller
>>> is USBSSP but it's to generic so I've decided to use CDNSP.
>>>
>>> The patch 1: adds support for DRD CDNSP.
>>> The patch 2: separates common code that can be reusable by cdnsp driver.
>>> The patch 3: moves reusable code to separate module.
>>> The patch 4: changes prefixes in reusable code from cdns3 to common cdns.
>>> The patch 5: adopts gadget_dev pointer in cdns structure to make possible
>>>              use it in both drivers.
>>> The patches 6-8: add the main part of driver and has been intentionally
>>>              split into 3 part. In my opinion such division should not
>>>              affect understanding and reviewing the driver, and cause that
>>>              main patch (7/8) is little smaller. Patch 6 introduces main
>>>              header file for driver, 7 is the main part that implements all
>>>              functionality of driver and 8 introduces tracepoints.
>>> The patch 9: Adds cdns3 prefixes to files related with USBSS driver.
>>> the patch 10: Adds USBSSP DRD IP driver entry to MAINTAINERS file.
>>>
>>> Changlog from v2:
>>> - removed not used pdev parameter from cdnsp_read/wite_64 functions
>>> - fixed incorrect value assigned to CDNSP_ENDPOINTS_NUM (32 -> 31)
>>> - replaced some constant value with CDNSP_ENDPOINTS_NUM macro
>>> - replaced 'true' with '1' in bits description in cdnsp-gadget.h file
>>> - fixed some typos
>>> - some other less important changes suggested by Peter Chen
>>
>>Hi Pawel,
>>
>>I have updated my -next tree as the latest usb-next tree which v5.10-rc4
>>is included, would you please rebase my tree and send again, I could apply your
>>patches and test, if test could pass, I will apply it to my -next tree.
>>You don't need to rebase again since it is a huge patch set, will take some
>>efforts for rebase.
>>
>
>I'll try to post it tomorrow.

Can I send the new version CDNSP or I should wait for completion
'Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"' and 
applying the appropriate fix to your repo ?

<snip>

Thanks
Pawel

  parent reply	other threads:[~2020-11-25  6:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 14:12 [PATCH v3 00/10] Introduced new Cadence USBSSP DRD Driver Pawel Laszczak
2020-11-19 14:12 ` [PATCH v3 01/10] usb: cdns3: Add support for DRD CDNSP Pawel Laszczak
2020-11-19 14:12 ` [PATCH v3 02/10] usb: cdns3: Split core.c into cdns3-plat and core.c file Pawel Laszczak
2020-11-19 14:13 ` [PATCH v3 03/10] usb: cdns3: Moves reusable code to separate module Pawel Laszczak
2020-11-19 14:13 ` [PATCH v3 04/10] usb: cdns3: Refactoring names in reusable code Pawel Laszczak
2020-11-19 14:13 ` [PATCH v3 05/10] usb: cdns3: Changed type of gadget_dev in cdns structure Pawel Laszczak
2020-11-19 14:13 ` [PATCH v3 06/10] usb: cdnsp: Device side header file for CDNSP driver Pawel Laszczak
2020-11-19 14:13 ` [PATCH v3 07/10] usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver Pawel Laszczak
2020-11-19 14:13 ` [PATCH v3 08/10] usb: cdnsp: Add tracepoints for CDNSP driver Pawel Laszczak
2020-11-19 14:13 ` [PATCH v3 09/10] usb: cdns3: Change file names for cdns3 driver Pawel Laszczak
2020-11-19 14:13 ` [PATCH v3 10/10] MAINTAINERS: add Cadence USBSSP DRD IP driver entry Pawel Laszczak
2020-11-25  1:10   ` Peter Chen
2020-11-25  4:41     ` Pawel Laszczak
2020-11-24  7:50 ` [PATCH v3 00/10] Introduced new Cadence USBSSP DRD Driver Peter Chen
2020-11-24  9:21   ` Pawel Laszczak
2020-11-24  9:35     ` Sekhar Nori
2020-11-24  9:52       ` Pawel Laszczak
2020-11-25 15:03         ` Sekhar Nori
2020-11-25  6:07     ` Pawel Laszczak [this message]
2020-11-25  6:53       ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR07MB55294D86FE79E85F41838918DDFA0@DM6PR07MB5529.namprd07.prod.outlook.com \
    --to=pawell@cadence.com \
    --cc=balbi@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kurahul@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=peter.chen@nxp.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).