RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC

From: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Hunter, Adrian" <adrian.hunter@intel.com>,
	"Raja Subramanian,
	Lakshmi Bai"  <lakshmi.bai.raja.subramanian@intel.com>,
	"Wan Mohamad,
	Wan Ahmad Zainie"  <wan.ahmad.zainie.wan.mohamad@intel.com>,
	"David E. Box" <david.e.box@linux.intel.com>
Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC
Date: Tue, 17 Nov 2020 13:46:42 +0000	[thread overview]
Message-ID: <DM6PR11MB2876A043535B8EDE5286FBB0B8E20@DM6PR11MB2876.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAPDyKFpVJ0jGkqa2j9W-Z-su3vT2eSKHkObYj1Z0C3MvRQrKwg@mail.gmail.com>

Hi Ulf,

>-----Original Message-----
>From: Ulf Hansson <ulf.hansson@linaro.org>
>Sent: Tuesday, November 17, 2020 7:27 PM
>To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com>
>Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm-
>kernel@lists.infradead.org>; Linux Kernel Mailing List <linux-
>kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; Raja
>Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Wan
>Mohamad, Wan Ahmad Zainie
><wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box
><david.e.box@linux.intel.com>
>Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay
>SOC
>
>On Mon, 16 Nov 2020 at 15:22, Zulkifli, Muhammad Husaini
><muhammad.husaini.zulkifli@intel.com> wrote:
>>
>> Hi Ulf,
>>
>> Thanks for your review comments. I replied inline
>>
>> >-----Original Message-----
>> >From: Ulf Hansson <ulf.hansson@linaro.org>
>> >Sent: Monday, November 16, 2020 7:41 PM
>> >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com>
>> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm-
>> >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux-
>> >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>;
>> >Raja Subramanian, Lakshmi Bai
>> ><lakshmi.bai.raja.subramanian@intel.com>; Wan Mohamad, Wan Ahmad
>> >Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box
>> ><david.e.box@linux.intel.com>
>> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops
>> >for Keem Bay SOC
>> >
>> >On Fri, 6 Nov 2020 at 05:10, <muhammad.husaini.zulkifli@intel.com> wrote:
>> >>
>> >> From: Muhammad Husaini Zulkifli
>> >> <muhammad.husaini.zulkifli@intel.com>
>> >>
>> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations
>> >> handling") introduces platform specific SDHCI clock operation.
>> >>
>> >> This patch declares the clock operation for Keem Bay.
>> >> Add clk_ops for SD, EMMC and SDIO operations.
>> >
>> >The above commit message doesn't really tell why or what goes on here.
>> >Can please try to clarify that.
>>
>> We missed out the clock operation handling patch (Commit 16ada730a759)
>> and did not handle the clk_ops  for Keem Bay SOC devices.
>> These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86)  are
>merged at around the same time.
>> We catch the issue later when trying to boot into v5.10-rc1 with Keem Bay
>EVM.
>> That is why I created this patch to handle the clk_ops for Keem Bay devices.
>
>Alright, so the previous changes were simply not sufficient to complete the
>support.
>
>>
>> >
>> >>
>> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel
>> >> Keem
>> >> Bay")
>> >
>> >Is $subject patch fixing a bug/regression?
>>
>> This is to fix issue on previous commit. It is a bug fix.
>
>Has it ever worked?

Yes it is working. Tested with Keem Bay EVM. 
SD/EMMC/SDIO devices registered successfully with this fix.  

>
>Did the commit you point to with the fixes tag, break some other existing
>functionality?

It should not break other existing functionality. 
This is specific for Keem Bay SOC only.

>
>[...]
>
>Kind regards
>Uffe