From: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"Wan Mohamad,
Wan Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>,
Mark Gross <mgross@linux.intel.com>
Subject: RE: [PATCH v6 4/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC
Date: Sat, 12 Dec 2020 14:06:07 +0000 [thread overview]
Message-ID: <DM6PR11MB2876D9A7836F6C677D20EBB3B8C90@DM6PR11MB2876.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CACRpkda9TfKnKSJ+yBEn6uqvAEoTFXy-g-6GqJaUQ0FYHLP3iw@mail.gmail.com>
Hi Linus,
>-----Original Message-----
>From: Linus Walleij <linus.walleij@linaro.org>
>Sent: Sunday, December 6, 2020 7:02 AM
>To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com>
>Cc: Ulf Hansson <ulf.hansson@linaro.org>; Hunter, Adrian
><adrian.hunter@intel.com>; Michal Simek <michal.simek@xilinx.com>; linux-
>mmc <linux-mmc@vger.kernel.org>; Linux ARM <linux-arm-
>kernel@lists.infradead.org>; linux-kernel@vger.kernel.org; Shevchenko,
>Andriy <andriy.shevchenko@intel.com>; Raja Subramanian, Lakshmi Bai
><lakshmi.bai.raja.subramanian@intel.com>; Wan Mohamad, Wan Ahmad
>Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>; Mark Gross
><mgross@linux.intel.com>
>Subject: Re: [PATCH v6 4/4] mmc: sdhci-of-arasan: Enable UHS-1 support for
>Keem Bay SOC
>
>On Thu, Dec 3, 2020 at 8:10 AM Zulkifli, Muhammad Husaini
><muhammad.husaini.zulkifli@intel.com> wrote:
>
>> >Yeah it has to be called from somewhere, if you want an abstraction
>> >to make the driver neutral to any machine, then use a selector
>> >regulator. It can be placed anywhere in the kernel as long as you can
>reference it.
>>
>> Sorry. I am not really aware of selector regulator. Can you point me
>> to any references for this?
>
>It is part of the regulator subsystem and the standard framework there to
>handle regulators with an enumerable number of specific voltage levels.
>
>> IMHO, we do not need to overengineered it to add custom selector
>> regulator just to suit this Keem Bay HW design.
>
>That can be said about a lot of things we model with vqmmc.
>Using standard abstractions makes things easier for maintainers.
>We mostly design abstractions for maintenance not for the simplest way to
>set bits in registers.
Thanks for your input. I will try model it similar to current regulator implementation
specific for keem bay SoC where this keem bay regulator will encapsulated the
Secure Monitor Calling Convention (SMCCC) during voltage operations.
>
>Yours,
>Linus Walleij
prev parent reply other threads:[~2020-12-12 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 15:02 [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
2020-12-02 10:53 ` Ulf Hansson
2020-12-02 12:25 ` Shevchenko, Andriy
2020-12-02 12:41 ` Ulf Hansson
2020-12-02 13:10 ` Andy Shevchenko
2020-12-02 14:10 ` Ulf Hansson
2020-12-02 14:34 ` Andy Shevchenko
2020-12-02 14:38 ` Zulkifli, Muhammad Husaini
2020-12-02 15:02 ` [PATCH v6 1/4] mmc: sdhci-of-arasan: Add structure device pointer in probe func muhammad.husaini.zulkifli
2020-12-02 15:02 ` [PATCH v6 2/4] firmware: keembay: Add support for Trusted Firmware Service call muhammad.husaini.zulkifli
2020-12-02 15:02 ` [PATCH v6 3/4] dt-bindings: mmc: Add phys, vmmc and vqmmc supplies for Keem Bay SOC muhammad.husaini.zulkifli
2020-12-02 15:02 ` [PATCH v6 4/4] mmc: sdhci-of-arasan: Enable UHS-1 support " muhammad.husaini.zulkifli
2020-12-02 18:54 ` Linus Walleij
2020-12-03 7:10 ` Zulkifli, Muhammad Husaini
2020-12-03 8:12 ` Shevchenko, Andriy
2020-12-05 23:01 ` Linus Walleij
2020-12-12 14:06 ` Zulkifli, Muhammad Husaini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2876D9A7836F6C677D20EBB3B8C90@DM6PR11MB2876.namprd11.prod.outlook.com \
--to=muhammad.husaini.zulkifli@intel.com \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=michal.simek@xilinx.com \
--cc=ulf.hansson@linaro.org \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).