From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: Aaron Ma <aaron.ma@canonical.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
"kai.heng.feng@canonical.com" <kai.heng.feng@canonical.com>,
"Neftin, Sasha" <sasha.neftin@intel.com>
Subject: RE: [Intel-wired-lan] [v4][PATCH] e1000e: continue to init phy even when failed to disable ULP
Date: Tue, 28 Jul 2020 20:34:41 +0000 [thread overview]
Message-ID: <DM6PR11MB2890F94DA893CE56A5D8A3EABC730@DM6PR11MB2890.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200618065453.12140-1-aaron.ma@canonical.com>
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Aaron Ma
> Sent: Wednesday, June 17, 2020 11:55 PM
> To: kuba@kernel.org; Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>;
> davem@davemloft.net; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Lifshits, Vitaly
> <vitaly.lifshits@intel.com>; kai.heng.feng@canonical.com; Neftin, Sasha
> <sasha.neftin@intel.com>
> Subject: [Intel-wired-lan] [v4][PATCH] e1000e: continue to init phy even when
> failed to disable ULP
>
> After 'commit e086ba2fccda4 ("e1000e: disable s0ix entry and exit flows
> for ME systems")',
> ThinkPad P14s always failed to disable ULP by ME.
> 'commit 0c80cdbf3320 ("e1000e: Warn if disabling ULP failed")'
> break out of init phy:
>
> error log:
> [ 42.364753] e1000e 0000:00:1f.6 enp0s31f6: Failed to disable ULP
> [ 42.524626] e1000e 0000:00:1f.6 enp0s31f6: PHY Wakeup cause - Unicast
> Packet
> [ 42.822476] e1000e 0000:00:1f.6 enp0s31f6: Hardware Error
>
> When disable s0ix, E1000_FWSM_ULP_CFG_DONE will never be 1.
> If continue to init phy like before, it can work as before.
> iperf test result good too.
>
> Fixes: 0c80cdbf3320 ("e1000e: Warn if disabling ULP failed")
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
> drivers/net/ethernet/intel/e1000e/ich8lan.c | 1 -
> 1 file changed, 1 deletion(-)
I never did find a system that triggered the initial problem, but from a compatibility with the set of systems I do have working...
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
prev parent reply other threads:[~2020-07-28 20:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 10:05 [PATCH] e1000e: continue to init phy even when failed to disable ULP Aaron Ma
2020-06-16 10:20 ` [Intel-wired-lan] " Paul Menzel
2020-06-16 10:31 ` Aaron Ma
2020-06-16 11:23 ` Kai-Heng Feng
2020-06-16 11:26 ` Aaron Ma
2020-06-17 11:12 ` [v2][PATCH] " Aaron Ma
2020-06-17 16:28 ` Jakub Kicinski
2020-06-18 6:45 ` [v3][PATCH] " Aaron Ma
2020-06-18 6:54 ` [v4][PATCH] " Aaron Ma
2020-07-28 20:34 ` Brown, Aaron F [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2890F94DA893CE56A5D8A3EABC730@DM6PR11MB2890.namprd11.prod.outlook.com \
--to=aaron.f.brown@intel.com \
--cc=aaron.ma@canonical.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).