From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
"R, Dharageswari" <dharageswari.r@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Jie Yang <yang.jie@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Ben Zhang <benzh@chromium.org>, Mark Brown <broonie@kernel.org>,
"Nujella, Sathyanarayana" <sathyanarayana.nujella@intel.com>,
Fred Oh <fred.oh@linux.intel.com>,
"M, Naveen" <naveen.m@intel.com>,
Libin Yang <libin.yang@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
"Zhi, Yong" <yong.zhi@intel.com>
Subject: RE: [PATCH] ASoC: intel: sof_rt5682: Add support for tgl_rt1011_rt5682
Date: Thu, 3 Dec 2020 15:57:19 +0000 [thread overview]
Message-ID: <DM6PR11MB3642703026686BCA8200BE2F97F20@DM6PR11MB3642.namprd11.prod.outlook.com> (raw)
In-Reply-To: <9d3d76fd-869c-ec20-0fa0-a0da88e32502@linux.intel.com>
> > +struct {
> > + unsigned int tx;
> > + unsigned int rx;
> > +} rt1011_tdm_mask[] = {
> > + {.tx = 0x4, .rx = 0x1},
> > + {.tx = 0x8, .rx = 0x2},
> > +};
>
> as noted in the GitHub review this should be static and possibly const.
Will fix in v2. Also add const to structures in soc-acpi-intel-tgl-match.c
and include file in sof_realtek_common.c
Regards,
Brent
prev parent reply other threads:[~2020-12-03 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 1:58 [PATCH] ASoC: intel: sof_rt5682: Add support for tgl_rt1011_rt5682 Brent Lu
2020-12-02 15:18 ` Pierre-Louis Bossart
2020-12-03 15:57 ` Lu, Brent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3642703026686BCA8200BE2F97F20@DM6PR11MB3642.namprd11.prod.outlook.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=benzh@chromium.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dharageswari.r@intel.com \
--cc=fred.oh@linux.intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=libin.yang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).