From: "Lu, Brent" <brent.lu@intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Guennadi Liakhovetski" <guennadi.liakhovetski@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] ASoC: hdac_hdmi: support 'ELD' mixer
Date: Tue, 18 Aug 2020 14:49:50 +0000 [thread overview]
Message-ID: <DM6PR11MB3642F2053B86CD4FE10383E1975C0@DM6PR11MB3642.namprd11.prod.outlook.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2008181311430.3186@eliteleevi.tm.intel.com>
>
> This is a bit iffy part. If same PCM is connected to multiple receivers, you
> return ELD data for the first one and ignore the rest. OTOH, this is inline with
> comment in hdac_hdmi_get_port_from_cvt() in that this pcm-to-many
> routing is not really supported by the driver now. But jack status reporting is
> done a port basis, not per PCM/CVTs, so this is not fully aligned.
>
> Hmm. Given the proposed patch is aligned with the user-space interface
> exposed by patch_hdmi.c, I'm ok to go with this. Can you add an explicit
> comment to explain what is happening above?
>
> Br, Kai
Fix it in v3. Thank you for the review.
Regards,
Brent
next prev parent reply other threads:[~2020-08-18 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 8:34 [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer Brent Lu
2020-08-16 7:50 ` Takashi Iwai
2020-08-18 0:53 ` Lu, Brent
2020-08-18 0:44 ` [PATCH v2] " Brent Lu
2020-08-18 11:45 ` Kai Vehmanen
2020-08-18 14:49 ` Lu, Brent [this message]
2020-08-18 14:36 ` [PATCH v3] " Brent Lu
2020-08-18 15:02 ` Mark Brown
2020-08-18 15:22 ` Lu, Brent
2020-08-18 17:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3642F2053B86CD4FE10383E1975C0@DM6PR11MB3642.namprd11.prod.outlook.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).