linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Wu, Hao" <hao.wu@intel.com>
To: "Xu, Yilun" <yilun.xu@intel.com>
Cc: "mdf@kernel.org" <mdf@kernel.org>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"trix@redhat.com" <trix@redhat.com>,
	"lgoncalv@redhat.com" <lgoncalv@redhat.com>,
	Matthew Gerlach <matthew.gerlach@linux.intel.com>,
	"Weight, Russell H" <russell.h.weight@intel.com>
Subject: RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
Date: Thu, 9 Jul 2020 10:14:16 +0000	[thread overview]
Message-ID: <DM6PR11MB3819D07348C347B5BB8F86C085640@DM6PR11MB3819.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200709093527.GA32541@yilunxu-OptiPlex-7050>

> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > > Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> > >
> > > Add PCIe Device ID for Intel FPGA PAC N3000.
> > >
> > > Signed-off-by: Wu Hao <hao.wu@intel.com>
> > > Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > > ---
> > >  drivers/fpga/dfl-pci.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > > index 73b5153..824aecf 100644
> > > --- a/drivers/fpga/dfl-pci.c
> > > +++ b/drivers/fpga/dfl-pci.c
> > > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> > >  #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > >  #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > >  #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > > +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> >
> > Should we drop _PF_ here? and also do you want _INTEL_ here?
> 
> I think we could keep _PF_, also there is no need to support VF of pac
> n3000 in product now, but it does exist (ID: 0x0b31).
> 
> And add _INTEL_ is good to me.
> 
> Then how about this one:
>   #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000	0x0B30

I am just considering the alignment with ids defined in include/linux/pci_ids.h
So drop _PF_ before _INTEL_ would be better? : )

Thanks
Hao

  reply	other threads:[~2020-07-09 10:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09  8:18 [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 Xu Yilun
2020-07-09  9:10 ` Wu, Hao
2020-07-09  9:35   ` Xu Yilun
2020-07-09 10:14     ` Wu, Hao [this message]
2020-07-09 13:00       ` Tom Rix
2020-07-10  5:24         ` Xu Yilun
2020-07-10  6:14           ` Wu, Hao
2020-07-10 15:46             ` Moritz Fischer
2020-07-13  1:52               ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3819D07348C347B5BB8F86C085640@DM6PR11MB3819.namprd11.prod.outlook.com \
    --to=hao.wu@intel.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.gerlach@linux.intel.com \
    --cc=mdf@kernel.org \
    --cc=russell.h.weight@intel.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).