From: "Mani, Rajmohan" <rajmohan.mani@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Ayman Bagabas" <ayman.bagabas@gmail.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Joseph, Jithu" <jithu.joseph@intel.com>,
"Blaž Hrastnik" <blaz@mxxn.io>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"pmalani@chromium.org" <pmalani@chromium.org>,
"bleung@chromium.org" <bleung@chromium.org>
Subject: RE: [PATCH 2/2] usb: typec: intel_pmc_mux: Check the port status before connect
Date: Fri, 17 Jul 2020 06:04:51 +0000 [thread overview]
Message-ID: <DM6PR11MB39632A8236161E4A27FAB1BBF67C0@DM6PR11MB3963.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200716070508.GB962748@kroah.com>
Hi Greg,
> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Thursday, July 16, 2020 12:05 AM
> To: Mani, Rajmohan <rajmohan.mani@intel.com>
> Cc: Darren Hart <dvhart@infradead.org>; Andy Shevchenko
> <andy@infradead.org>; Mika Westerberg
> <mika.westerberg@linux.intel.com>; Dmitry Torokhov
> <dmitry.torokhov@gmail.com>; Lee Jones <lee.jones@linaro.org>; Ayman
> Bagabas <ayman.bagabas@gmail.com>; Masahiro Yamada
> <masahiroy@kernel.org>; Joseph, Jithu <jithu.joseph@intel.com>; Blaž
> Hrastnik <blaz@mxxn.io>; Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com>; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org; Heikki Krogerus
> <heikki.krogerus@linux.intel.com>; linux-usb@vger.kernel.org;
> pmalani@chromium.org; bleung@chromium.org
> Subject: Re: [PATCH 2/2] usb: typec: intel_pmc_mux: Check the port status
> before connect
>
> On Wed, Jul 15, 2020 at 05:33:10PM -0700, Rajmohan Mani wrote:
> > From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
> > The PMC microcontroller that we use for configuration, does not supply
> > any status information back. For port status we need to talk to
> > another controller on the board called IOM (I/O manager).
> >
> > By checking the port status before configuring the muxes, we can make
> > sure that we do not reconfigure the port after bootup when the system
> > firmware (for example BIOS) has already configured it.
> >
> > Using the status information also to check if DisplayPort HPD is still
> > asserted when the cable plug is disconnected, and clearing it if it
> > is.
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> You can't just forward on patches from others without also adding your
> signed-off-by to them, right?
>
Sorry I missed this.
> Please fix up this series and try again.
>
Ack. Will fix this with v2.
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2020-07-17 6:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 0:33 [PATCH 0/2] Add Intel Input Output Manager driver Rajmohan Mani
2020-07-16 0:33 ` [PATCH 1/2] platform/x86: Add Intel Input Output Manager (IOM) driver Rajmohan Mani
2020-07-16 7:09 ` Greg Kroah-Hartman
2020-07-17 6:03 ` Mani, Rajmohan
2020-07-17 6:18 ` Greg Kroah-Hartman
2020-07-24 5:15 ` Mani, Rajmohan
2020-07-16 0:33 ` [PATCH 2/2] usb: typec: intel_pmc_mux: Check the port status before connect Rajmohan Mani
2020-07-16 7:05 ` Greg Kroah-Hartman
2020-07-17 6:04 ` Mani, Rajmohan [this message]
2020-07-17 6:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB39632A8236161E4A27FAB1BBF67C0@DM6PR11MB3963.namprd11.prod.outlook.com \
--to=rajmohan.mani@intel.com \
--cc=andy@infradead.org \
--cc=ayman.bagabas@gmail.com \
--cc=blaz@mxxn.io \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jithu.joseph@intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).