* [PATCH] media: ov2740: select regmap
@ 2020-09-30 1:13 Sergey Senozhatsky
2020-10-06 3:22 ` Cao, Bingbu
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Senozhatsky @ 2020-09-30 1:13 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Bingbu Cao
Cc: Sakari Ailus, linux-media, linux-kernel, Sergey Senozhatsky
Fix OV2740 build breakage by selecting REGMAP_I2C config:
ov2740.c:1011:23: error: variable has incomplete type 'struct regmap_config'
struct regmap_config regmap_config = { };
^
ov2740.c:1011:9: note: forward declaration of 'struct regmap_config'
struct regmap_config regmap_config = { };
^
ov2740.c:1028:11: error: implicit declaration of function 'devm_regmap_init_i2c'
regmap = devm_regmap_init_i2c(client, ®map_config);
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 878f66ef2719..c64326ca331c 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -877,6 +877,7 @@ config VIDEO_OV2740
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
+ select REGMAP_I2C
help
This is a Video4Linux2 sensor driver for the OmniVision
OV2740 camera.
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] media: ov2740: select regmap
2020-09-30 1:13 [PATCH] media: ov2740: select regmap Sergey Senozhatsky
@ 2020-10-06 3:22 ` Cao, Bingbu
0 siblings, 0 replies; 2+ messages in thread
From: Cao, Bingbu @ 2020-10-06 3:22 UTC (permalink / raw)
To: Sergey Senozhatsky, Mauro Carvalho Chehab
Cc: Sakari Ailus, linux-media, linux-kernel
Sergey, thanks for your patch.
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
________________________
BRs,
Bingbu Cao
> -----Original Message-----
> From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Sent: Wednesday, September 30, 2020 9:13 AM
> To: Mauro Carvalho Chehab <mchehab@kernel.org>; Cao, Bingbu
> <bingbu.cao@intel.com>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>; linux-media@vger.kernel.org;
> linux-kernel@vger.kernel.org; Sergey Senozhatsky
> <sergey.senozhatsky@gmail.com>
> Subject: [PATCH] media: ov2740: select regmap
>
> Fix OV2740 build breakage by selecting REGMAP_I2C config:
>
> ov2740.c:1011:23: error: variable has incomplete type 'struct regmap_config'
> struct regmap_config regmap_config = { };
> ^
> ov2740.c:1011:9: note: forward declaration of 'struct regmap_config'
> struct regmap_config regmap_config = { };
> ^
> ov2740.c:1028:11: error: implicit declaration of function
> 'devm_regmap_init_i2c'
> regmap = devm_regmap_init_i2c(client, ®map_config);
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index
> 878f66ef2719..c64326ca331c 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -877,6 +877,7 @@ config VIDEO_OV2740
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> + select REGMAP_I2C
> help
> This is a Video4Linux2 sensor driver for the OmniVision
> OV2740 camera.
> --
> 2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-06 3:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 1:13 [PATCH] media: ov2740: select regmap Sergey Senozhatsky
2020-10-06 3:22 ` Cao, Bingbu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).