From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"authored:2/16=12%,added_lines:21/248=8%,removed_lines:5/84=6%,),Liam
Girdwood DRIVERS )" <lgirdwood@gmail.com>,
"commit_signer:6/16=38%,authored:6/16=38%,added_lines:123/248=50%
,removed_lines:36/84=43%,Kai Vehmanen DRIVERS )"
<kai.vehmanen@linux.intel.com>,
"Daniel Baluta DRIVERS )" <daniel.baluta@nxp.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
Zhu Yingjiang <yingjiang.zhu@linux.intel.com>,
Keyon Jie <yang.jie@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
"sound-open-firmware@alsa-project.orgDRIVERS"
<sound-open-firmware@alsa-project.orgDRIVERS>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response
Date: Thu, 11 Jun 2020 23:33:59 +0000 [thread overview]
Message-ID: <DM6PR11MB43168DD90582B665DF0F7D6397800@DM6PR11MB4316.namprd11.prod.outlook.com> (raw)
In-Reply-To: <b7e98ae0-ea42-bced-1c0f-caa73e798908@linux.intel.com>
>
> IIRC we added this loop before merging all interrupt handling in one thread,
> somehow the MSI mode never worked reliably without this change, so
> maybe we don't need this loop any longer.
>
> I'd really prefer it if we didn't tie the RIRB handing change to this loop change,
> removing the loop should only be done with *a lot of testing*.
The reason I removed the loop because I thought it's for the unsolicited response,
apparently it's not. I'd like to port the commit 6d011d5057ff
ALSA: hda: Clear RIRB status before reading WP
to SOF driver and upload a version 2. Thanks.
Regards,
Brent
next prev parent reply other threads:[~2020-06-11 23:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1591883073-17190-1-git-send-email-brent.lu@intel.com>
[not found] ` <b7e0b822a9deea506acaa40e0e31cc9f488bb446.camel@linux.intel.com>
2020-06-11 17:09 ` [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response Lu, Brent
2020-06-11 17:59 ` Takashi Iwai
2020-06-11 18:12 ` Ranjani Sridharan
2020-06-11 20:14 ` Takashi Iwai
2020-06-11 20:36 ` Pierre-Louis Bossart
2020-06-11 23:33 ` Lu, Brent [this message]
2020-06-12 6:15 ` Lu, Brent
2020-06-11 18:01 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB43168DD90582B665DF0F7D6397800@DM6PR11MB4316.namprd11.prod.outlook.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.orgDRIVERS \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=yang.jie@linux.intel.com \
--cc=yingjiang.zhu@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).