From: "Gupta, Nipun" <Nipun.Gupta@amd.com>
To: Rob Herring <robh@kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"jeffrey.l.hugo@gmail.com" <jeffrey.l.hugo@gmail.com>,
"maz@kernel.org" <maz@kernel.org>,
"Gupta, Puneet (DCG-ENG)" <puneet.gupta@amd.com>,
"Michael.Srba@seznam.cz" <Michael.Srba@seznam.cz>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"will@kernel.org" <will@kernel.org>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"okaya@kernel.org" <okaya@kernel.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"song.bao.hua@hisilicon.com" <song.bao.hua@hisilicon.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"mani@kernel.org" <mani@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Agarwal, Nikhil" <nikhil.agarwal@amd.com>,
"Anand, Harpreet" <harpreet.anand@amd.com>,
"yishaih@nvidia.com" <yishaih@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"git (AMD-Xilinx)" <git@amd.com>,
"saravanak@google.com" <saravanak@google.com>,
"Radovanovic, Aleksandar" <aleksandar.radovanovic@amd.com>,
"Simek, Michal" <michal.simek@amd.com>,
"ndesaulniers@google.com" <ndesaulniers@google.com>
Subject: RE: [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree bindings
Date: Wed, 7 Sep 2022 03:13:12 +0000 [thread overview]
Message-ID: <DM6PR12MB3082B9C670B5F58215259A76E8419@DM6PR12MB3082.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1662486402.681939.780022.nullmailer@robh.at.kernel.org>
[AMD Official Use Only - General]
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, September 6, 2022 11:17 PM
> To: Gupta, Nipun <Nipun.Gupta@amd.com>
> Cc: gregkh@linuxfoundation.org; eric.auger@redhat.com;
> devicetree@vger.kernel.org; linux-kbuild@vger.kernel.org;
> jeffrey.l.hugo@gmail.com; maz@kernel.org; Gupta, Puneet (DCG-ENG)
> <puneet.gupta@amd.com>; Michael.Srba@seznam.cz; cohuck@redhat.com;
> will@kernel.org; masahiroy@kernel.org; mchehab+huawei@kernel.org;
> joro@8bytes.org; okaya@kernel.org; alex.williamson@redhat.com;
> song.bao.hua@hisilicon.com; jgg@nvidia.com; mani@kernel.org; linux-
> kernel@vger.kernel.org; robin.murphy@arm.com; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; rafael@kernel.org; f.fainelli@gmail.com;
> jgg@ziepe.ca; kvm@vger.kernel.org; Agarwal, Nikhil
> <nikhil.agarwal@amd.com>; Anand, Harpreet <harpreet.anand@amd.com>;
> yishaih@nvidia.com; linux-arm-kernel@lists.infradead.org; git (AMD-Xilinx)
> <git@amd.com>; saravanak@google.com; Radovanovic, Aleksandar
> <aleksandar.radovanovic@amd.com>; Simek, Michal
> <michal.simek@amd.com>; ndesaulniers@google.com
> Subject: Re: [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree
> bindings
>
> [CAUTION: External Email]
>
> On Tue, 06 Sep 2022 19:17:55 +0530, Nipun Gupta wrote:
> > This patch adds a devicetree binding documentation for CDX
> > bus.
> >
> > CDX bus controller dynamically detects CDX bus and the
> > devices on these bus using CDX firmware.
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> > ---
> > .../devicetree/bindings/bus/xlnx,cdx.yaml | 75 +++++++++++++++++++
> > MAINTAINERS | 6 ++
> > 2 files changed, 81 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/bus/xlnx,cdx.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:18.23-21.11:
> Warning (unit_address_vs_reg): /example-0/smmu@ec000000: node has a unit
> name, but no reg or ranges property
> Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:23.22-30.11:
> Warning (unit_address_vs_reg): /example-0/gic@e2000000: node has a unit
> name, but no reg or ranges property
> Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:26.35-29.15:
> Warning (unit_address_vs_reg): /example-0/gic@e2000000/gic-its@e2040000:
> node has a unit name, but no reg or ranges property
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> smmu@ec000000: $nodename:0: 'smmu@ec000000' does not match
> '^iommu@[0-9a-f]*'
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> smmu@ec000000: 'reg' is a required property
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@e2000000: $nodename:0: 'gic@e2000000' does not match '^interrupt-
> controller(@[0-9a-f,]+)*$'
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@e2000000: '#interrupt-cells' is a dependency of 'interrupt-controller'
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@e2000000: 'reg' is a required property
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@e2000000: gic-its@e2040000: False schema does not allow {'compatible':
> ['arm,gic-v3-its'], 'msi-controller': True, 'phandle': [[1]]}
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@e2000000: gic-its@e2040000: '#msi-cells' is a required property
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@e2000000: gic-its@e2040000: 'reg' is a required property
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> gic@e2000000: 'oneOf' conditional failed, one must be fixed:
> 'interrupts' is a required property
> 'interrupts-extended' is a required property
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
> v3.yaml
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
> cdx@4000000: reg: [[0, 67108864], [0, 4096]] is too long
> From schema: /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/bus/xlnx,cdx.yaml
>
> doc reference errors (make refcheckdocs):
>
> See
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
> ork.ozlabs.org%2Fpatch%2F&data=05%7C01%7Cnipun.gupta%40amd.com
> %7C47f53d11f4024ba765f408da902fc525%7C3dd8961fe4884e608e11a82d994e
> 183d%7C0%7C0%7C637980832144301226%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7C&sdata=BXO1d2OWdCQ1lb%2BEDNiUvmfSPPfxfzJET%2B
> uuAL9EdEY%3D&reserved=0
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
I did run make dt_binding_check, but did not see the issue.
Will update the dtschema and fix this.
Thanks,
Nipun
next prev parent reply other threads:[~2022-09-07 3:13 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 12:26 [RFC PATCH 0/2] add support for CDX bus MSI domain Nipun Gupta
2022-08-03 12:26 ` [RFC PATCH 1/2] irqchip: cdx-bus: add cdx-MSI domain with gic-its domain as parent Nipun Gupta
2022-08-03 12:33 ` Greg KH
2022-08-03 12:37 ` Gupta, Nipun
2022-08-04 8:49 ` Marc Zyngier
2022-08-04 9:18 ` Gupta, Nipun
[not found] ` <87mtckwaxa.wl-maz@kernel.org>
2022-08-04 12:11 ` Gupta, Nipun
2022-08-03 12:26 ` [RFC PATCH 2/2] driver core: add compatible string in sysfs for platform devices Nipun Gupta
2022-08-03 12:31 ` Greg KH
2022-08-03 12:46 ` Gupta, Nipun
2022-08-03 14:16 ` [RFC PATCH 0/2] add support for CDX bus MSI domain Robin Murphy
2022-08-04 4:23 ` Gupta, Nipun
2022-08-17 16:00 ` Jason Gunthorpe
2022-08-17 15:05 ` [RFC PATCH v2 0/6] add support for CDX bus controller Nipun Gupta
2022-08-17 15:05 ` [RFC PATCH v2 1/6] Documentation: DT: Add entry for CDX controller Nipun Gupta
2022-08-18 9:54 ` Krzysztof Kozlowski
2022-08-18 9:59 ` Krzysztof Kozlowski
2022-09-05 14:05 ` Gupta, Nipun
2022-09-06 6:55 ` Krzysztof Kozlowski
2022-09-06 7:03 ` Gupta, Nipun
2022-09-06 7:20 ` Krzysztof Kozlowski
2022-08-17 15:05 ` [RFC PATCH v2 2/6] bus/cdx: add the cdx bus driver Nipun Gupta
2022-08-17 15:32 ` Greg KH
2022-08-17 15:46 ` Marc Zyngier
2022-08-22 13:21 ` Gupta, Nipun
2022-08-22 13:29 ` Greg KH
2022-08-24 8:50 ` Gupta, Nipun
2022-08-24 12:11 ` Greg KH
2022-08-24 23:31 ` Jason Gunthorpe
2022-08-25 18:38 ` Saravana Kannan
2022-08-25 19:57 ` Robin Murphy
2022-08-26 0:08 ` Jason Gunthorpe
2022-08-29 4:49 ` Gupta, Nipun
2022-08-29 4:49 ` Gupta, Nipun
2022-08-29 15:31 ` Jason Gunthorpe
2022-08-30 7:06 ` Gupta, Nipun
2022-08-30 11:25 ` Robin Murphy
2022-08-30 13:01 ` Jason Gunthorpe
2022-08-30 13:12 ` Gupta, Nipun
2022-08-17 15:05 ` [RFC PATCH v2 3/6] bus/cdx: add cdx-MSI domain with gic-its domain as parent Nipun Gupta
2022-08-17 15:33 ` Greg KH
2022-08-17 15:05 ` [RFC PATCH v2 4/6] bus/cdx: add rescan and reset support Nipun Gupta
2022-08-17 15:05 ` [RFC PATCH v2 5/6] vfio: platform: reset: add reset for cdx devices Nipun Gupta
2022-08-17 15:05 ` [RFC PATCH v2 6/6] driver core: add compatible string in sysfs for platform devices Nipun Gupta
2022-08-17 15:30 ` Greg KH
2022-08-17 16:04 ` Saravana Kannan
2022-09-05 13:54 ` Gupta, Nipun
2022-09-06 13:47 ` [RFC PATCH v3 0/7] add support for CDX bus Nipun Gupta
2022-09-06 13:47 ` [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree bindings Nipun Gupta
2022-09-06 17:46 ` Rob Herring
2022-09-07 3:13 ` Gupta, Nipun [this message]
2022-09-08 10:51 ` Krzysztof Kozlowski
2022-09-06 13:47 ` [RFC PATCH v3 2/7] bus/cdx: add the cdx bus driver Nipun Gupta
2022-09-07 0:32 ` Saravana Kannan
2022-09-07 3:21 ` Gupta, Nipun
2022-09-07 18:06 ` Saravana Kannan
2022-09-07 12:32 ` Greg KH
2022-09-08 13:29 ` Gupta, Nipun
2022-09-06 13:47 ` [RFC PATCH v3 3/7] iommu/arm-smmu-v3: support ops registration for CDX bus Nipun Gupta
2022-09-07 0:10 ` Saravana Kannan
2022-09-07 3:17 ` Gupta, Nipun
2022-09-07 8:27 ` Robin Murphy
2022-09-07 18:24 ` Saravana Kannan
2022-09-07 20:40 ` Robin Murphy
2022-09-08 0:14 ` Saravana Kannan
2022-09-06 13:47 ` [RFC PATCH v3 4/7] bus/cdx: add cdx-MSI domain with gic-its domain as parent Nipun Gupta
2022-09-06 17:19 ` Jason Gunthorpe
2022-09-07 11:17 ` Marc Zyngier
2022-09-07 11:33 ` Robin Murphy
2022-09-07 12:14 ` Marc Zyngier
2022-09-07 11:35 ` Radovanovic, Aleksandar
[not found] ` <87illzuzyw.wl-maz@kernel.org>
2022-09-07 13:18 ` Radovanovic, Aleksandar
[not found] ` <87edwmuw4f.wl-maz@kernel.org>
2022-09-08 9:51 ` Radovanovic, Aleksandar
2022-09-08 11:49 ` Robin Murphy
2022-09-07 13:18 ` Marc Zyngier
2022-09-08 14:13 ` Gupta, Nipun
[not found] ` <87a67aueg7.wl-maz@kernel.org>
2022-09-09 6:32 ` Gupta, Nipun
2022-10-12 10:04 ` Gupta, Nipun
2022-10-12 10:34 ` Radovanovic, Aleksandar
2022-10-12 13:02 ` Jason Gunthorpe
2022-10-12 13:37 ` Radovanovic, Aleksandar
2022-10-12 14:38 ` Jason Gunthorpe
2022-10-12 15:09 ` Radovanovic, Aleksandar
2022-10-13 12:43 ` Jason Gunthorpe
2022-10-14 11:18 ` Radovanovic, Aleksandar
2022-10-14 11:54 ` gregkh
2022-10-14 12:13 ` Radovanovic, Aleksandar
2022-10-14 13:46 ` gregkh
2022-10-14 13:58 ` Jason Gunthorpe
2022-09-06 13:47 ` [RFC PATCH v3 5/7] bus/cdx: add bus and device attributes Nipun Gupta
2022-09-06 13:48 ` [RFC PATCH v3 6/7] vfio/cdx: add support for CDX bus Nipun Gupta
2022-09-06 17:20 ` Jason Gunthorpe
2022-09-06 17:23 ` Gupta, Nipun
2022-09-06 13:48 ` [RFC PATCH v3 7/7] vfio/cdx: add interrupt support Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 0/8] add support for CDX bus Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 1/8] dt-bindings: bus: add CDX bus device tree bindings Nipun Gupta
2022-10-14 14:17 ` Rob Herring
2022-10-17 10:18 ` Gupta, Nipun
2022-10-14 4:40 ` [RFC PATCH v4 2/8] bus/cdx: add the cdx bus driver Nipun Gupta
2022-10-14 7:15 ` Greg KH
2022-10-14 8:12 ` Gupta, Nipun
2022-10-14 7:18 ` Greg KH
2022-10-14 8:20 ` Gupta, Nipun
2022-10-14 4:40 ` [RFC PATCH v4 3/8] iommu/arm-smmu-v3: support ops registration for CDX bus Nipun Gupta
2022-10-14 4:51 ` Gupta, Nipun
2022-10-14 4:40 ` [RFC PATCH v4 4/8] bux/cdx: support dma configuration for CDX devices Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 5/8] bus/cdx: add bus and device attributes Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 6/8] irq/msi: use implicit msi domain for alloc and free Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 7/8] bus/cdx: add cdx-MSI domain with gic-its domain as parent Nipun Gupta
2022-11-17 19:10 ` Thomas Gleixner
2022-10-14 4:40 ` [RFC PATCH v4 8/8] bus/cdx: add cdx controller Nipun Gupta
2022-10-14 14:10 ` [RFC PATCH v4 0/8] add support for CDX bus Rob Herring
2022-10-17 10:08 ` Gupta, Nipun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3082B9C670B5F58215259A76E8419@DM6PR12MB3082.namprd12.prod.outlook.com \
--to=nipun.gupta@amd.com \
--cc=Michael.Srba@seznam.cz \
--cc=aleksandar.radovanovic@amd.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harpreet.anand@amd.com \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=masahiroy@kernel.org \
--cc=maz@kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=michal.simek@amd.com \
--cc=ndesaulniers@google.com \
--cc=nikhil.agarwal@amd.com \
--cc=okaya@kernel.org \
--cc=puneet.gupta@amd.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=song.bao.hua@hisilicon.com \
--cc=will@kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).