From: "Limonciello, Mario" <Mario.Limonciello@dell.com>
To: Hans de Goede <hdegoede@redhat.com>,
Qinglang Miao <miaoqinglang@huawei.com>,
Mark Gross <mgross@linux.intel.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init
Date: Mon, 30 Nov 2020 21:50:12 +0000 [thread overview]
Message-ID: <DM6PR19MB26363C4F46BFBF973298F7E8FAF50@DM6PR19MB2636.namprd19.prod.outlook.com> (raw)
In-Reply-To: <9f86ac03-1c90-e6b6-4f7d-e9584a19e46d@redhat.com>
>
> Hi,
>
> +Cc Mario
>
> On 11/25/20 7:50 AM, Qinglang Miao wrote:
> > Fix to return the error code -ENODEV when fails to init wmi and
> > smm.
> >
> > Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-*
> modules together")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
>
> Mario, this seems like a trivial fix to me, but I'm not 100% sure, any
> comments on this?
>
> Regards,
>
> Hans
Yeah, it's reasonable to me.
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
>
>
> > ---
> > drivers/platform/x86/dell-smbios-base.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/dell-smbios-base.c
> b/drivers/platform/x86/dell-smbios-base.c
> > index 2e2cd5659..3a1dbf199 100644
> > --- a/drivers/platform/x86/dell-smbios-base.c
> > +++ b/drivers/platform/x86/dell-smbios-base.c
> > @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
> > if (wmi && smm) {
> > pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
> > wmi, smm);
> > + ret = -ENODEV;
> > goto fail_create_group;
> > }
> >
> >
next prev parent reply other threads:[~2020-11-30 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 6:50 [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init Qinglang Miao
2020-11-25 17:05 ` Hans de Goede
2020-11-30 21:50 ` Limonciello, Mario [this message]
2020-12-02 12:11 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR19MB26363C4F46BFBF973298F7E8FAF50@DM6PR19MB2636.namprd19.prod.outlook.com \
--to=mario.limonciello@dell.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=miaoqinglang@huawei.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).