From: "Limonciello, Mario" <Mario.Limonciello@dell.com>
To: Hans de Goede <hdegoede@redhat.com>,
"Enrico Weigelt, metux IT consult" <lkml@metux.net>,
Matthew Garrett <mjg59@srcf.ucam.org>,
"Yuan, Perry" <Perry.Yuan@dell.com>
Cc: "mgross@linux.intel.com" <mgross@linux.intel.com>,
"pali@kernel.org" <pali@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: RE: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver
Date: Thu, 12 Nov 2020 15:57:55 +0000 [thread overview]
Message-ID: <DM6PR19MB2636C714D1EE520F98617018FAE70@DM6PR19MB2636.namprd19.prod.outlook.com> (raw)
In-Reply-To: <544bc53f-c260-9e46-15a9-2ec2ea41343c@redhat.com>
> >
> > Again, if anything in this flow doesn't happen HW mic mute is still
> activated,
> > just will take longer (for duration of timeout) and have popping noise.
>
> Thank you, can we put this in a comment in the driver please ?
Yes, I agree. I suggested to Perry that his next submission of this driver
needs a lot more context in commit message (and it sounds like probably
code comments too).
>
> I guess this also means that the led_class device is just there to
> catch the ledtrig_audio_set() call so that dell-firmware can tell the
> EC that the sw-mute is done and that it can move ahead with the hw-mute.
>
> While the real, physical LED is fully under hardware control, right ?
>
> That should probably also be in the same comment in the driver
> (feel free to re-use part of my wording for that if that helps).
>
> Regards,
>
> Hans
Yes - exactly.
next prev parent reply other threads:[~2020-11-12 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 12:55 [PATCH] platform/x86: dell-privacy: Add support for new privacy driver Perry Yuan
2020-11-03 16:22 ` kernel test robot
2020-11-03 16:50 ` kernel test robot
2020-11-03 19:14 ` Barnabás Pőcze
2020-11-04 1:49 ` Matthew Garrett
2020-11-11 7:21 ` Yuan, Perry
2020-11-11 7:24 ` Matthew Garrett
2020-11-11 14:30 ` Limonciello, Mario
2020-11-12 15:06 ` Enrico Weigelt, metux IT consult
2020-11-12 15:31 ` Limonciello, Mario
2020-11-12 15:55 ` Hans de Goede
2020-11-12 15:57 ` Limonciello, Mario [this message]
2020-11-04 6:43 ` kernel test robot
2020-11-09 11:16 ` Hans de Goede
2020-11-11 7:24 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR19MB2636C714D1EE520F98617018FAE70@DM6PR19MB2636.namprd19.prod.outlook.com \
--to=mario.limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=mgross@linux.intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).