From: Peng Fan <peng.fan@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Tushar Khandelwal <Tushar.Khandelwal@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: RE: [PATCH 2/2] mailbox: imx: fix duplicated initializer
Date: Sat, 7 May 2022 06:52:28 +0000 [thread overview]
Message-ID: <DU0PR04MB9417AFDAFE3F06B3F9274E1888C49@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20220501103428.111286-2-krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer
>
> rxdb field is being initialized twice:
>
> drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [-
> Werror=override-init]
> 889 | .rxdb = imx_mu_generic_rxdb,
>
> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/mailbox/imx-mailbox.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index e88f544a1548..df8a785be324 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp =
> {
> .rx = imx_mu_generic_rx,
> .rxdb = imx_mu_generic_rxdb,
> .init = imx_mu_init_generic,
> - .rxdb = imx_mu_generic_rxdb,
> .type = IMX_MU_V2,
> .xTR = 0x200,
> .xRR = 0x280,
> --
> 2.32.0
next prev parent reply other threads:[~2022-05-07 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 10:34 [PATCH 1/2] mailbox: correct kerneldoc Krzysztof Kozlowski
2022-05-01 10:34 ` [PATCH 2/2] mailbox: imx: fix duplicated initializer Krzysztof Kozlowski
2022-05-07 6:52 ` Peng Fan [this message]
2022-06-20 18:39 ` Krzysztof Kozlowski
2022-06-20 19:48 ` Jassi Brar
2022-05-19 7:57 ` [PATCH 1/2] mailbox: correct kerneldoc Krzysztof Kozlowski
2022-05-19 11:07 ` Viresh Kumar
2022-05-19 15:13 ` Sudeep Holla
2022-05-19 15:14 ` Krzysztof Kozlowski
2022-05-19 15:19 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU0PR04MB9417AFDAFE3F06B3F9274E1888C49@DU0PR04MB9417.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=Tushar.Khandelwal@arm.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).