Re: [PATCH v6 0/5] Enable root to update the blacklist keyring

From: Eric Snowberg <eric.snowberg@oracle.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "David Howells" <dhowells@redhat.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Jarkko Sakkinen" <jarkko@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"James Morris" <jmorris@namei.org>,
	"Mickaël Salaün" <mic@linux.microsoft.com>,
	"Mimi Zohar" <zohar@linux.ibm.com>,
	"Serge E . Hallyn" <serge@hallyn.com>,
	"Tyler Hicks" <tyhicks@linux.microsoft.com>,
	keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-integrity <linux-integrity@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	"Eric Snowberg" <eric.snowberg@oracle.com>
Subject: Re: [PATCH v6 0/5] Enable root to update the blacklist keyring
Date: Mon, 22 Feb 2021 10:41:04 -0700	[thread overview]
Message-ID: <E00A6ADE-5634-4E75-8892-FF99AD77EA39@oracle.com> (raw)
In-Reply-To: <132a6049-e91b-3922-cd3f-89574dd049fe@digikod.net>

> On Feb 21, 2021, at 4:17 AM, Mickaël Salaün <mic@digikod.net> wrote:
> 
> David, Eric, what is the status of this patch series?

All the previous issues I had identified have been resolved, so LGTM.

> On 10/02/2021 13:04, Mickaël Salaün wrote:
>> This new patch series is a rebase on David Howells's keys-misc branch.
>> This mainly fixes UEFI DBX and the new Eric Snowberg's feature to import
>> asymmetric keys to the blacklist keyring.
>> I successfully tested this patch series with the 186 entries from
>> https://uefi.org/sites/default/files/resources/dbxupdate_x64.bin (184
>> binary hashes and 2 certificates).
>> 
>> The goal of these patches is to add a new configuration option to enable the
>> root user to load signed keys in the blacklist keyring.  This keyring is useful
>> to "untrust" certificates or files.  Enabling to safely update this keyring
>> without recompiling the kernel makes it more usable.
>> 
>> This can be applied on top of David Howells's keys-next branch:
>> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-next
>> Git commits can be found in https://github.com/l0kod/linux branch
>> dyn-auth-blacklist-v6 commit fcf976b74ffcd4551683e6b70dbf5fb102cf9906 .
>> 
>> Previous patch series:
>> https://lore.kernel.org/lkml/20210128191705.3568820-1-mic@digikod.net/
>> 
>> Regards,
>> 
>> Mickaël Salaün (5):
>>  tools/certs: Add print-cert-tbs-hash.sh
>>  certs: Check that builtin blacklist hashes are valid
>>  certs: Make blacklist_vet_description() more strict
>>  certs: Factor out the blacklist hash creation
>>  certs: Allow root user to append signed hashes to the blacklist
>>    keyring
>> 
>> MAINTAINERS                                   |   2 +
>> certs/.gitignore                              |   1 +
>> certs/Kconfig                                 |  17 +-
>> certs/Makefile                                |  17 +-
>> certs/blacklist.c                             | 218 ++++++++++++++----
>> crypto/asymmetric_keys/x509_public_key.c      |   3 +-
>> include/keys/system_keyring.h                 |  14 +-
>> scripts/check-blacklist-hashes.awk            |  37 +++
>> .../platform_certs/keyring_handler.c          |  26 +--
>> tools/certs/print-cert-tbs-hash.sh            |  91 ++++++++
>> 10 files changed, 346 insertions(+), 80 deletions(-)
>> create mode 100755 scripts/check-blacklist-hashes.awk
>> create mode 100755 tools/certs/print-cert-tbs-hash.sh
>> 
>> 
>> base-commit: 5bcd72358a7d7794ade0452ed12919b8c4d6ffc7
>> 