From: Eric Snowberg <eric.snowberg@oracle.com>
To: David Howells <dhowells@redhat.com>
Cc: dwmw2@infradead.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
herbert@gondor.apana.org.au, davem@davemloft.net,
jmorris@namei.org, serge@hallyn.com, nayna@linux.ibm.com,
Mimi Zohar <zohar@linux.ibm.com>,
erichte@linux.ibm.com, mpe@ellerman.id.au,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org,
Eric Snowberg <eric.snowberg@oracle.com>
Subject: Re: [PATCH v4] certs: Add EFI_CERT_X509_GUID support for dbx entries
Date: Thu, 10 Dec 2020 11:56:58 -0700 [thread overview]
Message-ID: <E090372C-06A3-4991-8FC3-F06A0DA60729@oracle.com> (raw)
In-Reply-To: <1360578.1607593748@warthog.procyon.org.uk>
> On Dec 10, 2020, at 2:49 AM, David Howells <dhowells@redhat.com> wrote:
>
> Eric Snowberg <eric.snowberg@oracle.com> wrote:
>
>> Add support for EFI_CERT_X509_GUID dbx entries. When a EFI_CERT_X509_GUID
>> is found, it is added as an asymmetrical key to the .blacklist keyring.
>> Anytime the .platform keyring is used, the keys in the .blacklist keyring
>> are referenced, if a matching key is found, the key will be rejected.
>
> Ummm... Why this way and not as a blacklist key which takes up less space?
> I'm guessing that you're using the key chain matching logic. We really only
> need to blacklist the key IDs.
I implemented it this way so that certs in the dbx would only impact
the .platform keyring. I was under the impression we didn’t want to have
Secure Boot UEFI db/dbx certs dictate keyring functionality within the kernel
itself. Meaning if we have a matching dbx cert in any other keyring (builtin,
secondary, ima, etc.), it would be allowed. If that is not how you’d like to
see it done, let me know and I’ll make the change.
> Also, what should happen if a revocation cert rejected by the blacklist?
I’m not sure I understand the question. How would it be rejected?
>> +int mark_key_revocationlisted(const char *data, size_t size)
>
> Hmmm... The name looks wrong, but I can see the potential issue that kernel
> keys can actually be marked revoked as a separate concept. How about
> add_key_to_revocation_list() and is_key_on_revocation_list().
I'll update the names in the next version.
Thanks.
next prev parent reply other threads:[~2020-12-10 18:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 0:49 [PATCH v4] certs: Add EFI_CERT_X509_GUID support for dbx entries Eric Snowberg
2020-09-16 18:09 ` Jarkko Sakkinen
2020-12-10 9:49 ` David Howells
2020-12-10 18:56 ` Eric Snowberg [this message]
2021-01-12 14:57 ` David Howells
2021-01-13 20:41 ` Jarkko Sakkinen
2021-01-14 0:11 ` Eric Snowberg
2021-01-15 9:15 ` Jarkko Sakkinen
2021-01-15 16:49 ` Eric Snowberg
2021-01-20 11:26 ` Jarkko Sakkinen
2021-01-20 22:13 ` Eric Snowberg
2021-01-21 0:36 ` Jarkko Sakkinen
2021-01-27 11:46 ` David Howells
2021-01-27 14:03 ` Mimi Zohar
2021-01-27 15:41 ` Eric Snowberg
2021-01-28 4:13 ` Nayna
2021-01-30 10:24 ` Jarkko Sakkinen
2021-01-29 23:27 ` Jarkko Sakkinen
2021-01-12 17:10 ` David Howells
2021-01-12 19:13 ` Eric Snowberg
2021-01-15 17:21 ` James Bottomley
2021-01-15 23:01 ` Eric Snowberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E090372C-06A3-4991-8FC3-F06A0DA60729@oracle.com \
--to=eric.snowberg@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=erichte@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).