From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: jgarzik@mandrakesoft.com (Jeff Garzik)
Cc: jgolds@resilience.com (Jeff Golds), linux-kernel@vger.kernel.org
Subject: Re: Problems with arch/i386/kernel/apm.c
Date: Mon, 11 Jun 2001 19:42:36 +0100 (BST) [thread overview]
Message-ID: <E159We4-0000Cc-00@the-village.bc.nu> (raw)
In-Reply-To: <3B2509CD.F898D2AE@mandrakesoft.com> from "Jeff Garzik" at Jun 11, 2001 02:11:25 PM
> > needed. What I am really desiring to know is if there are any devices
> > that depend on the apm::send_event(APM_NORMAL_RESUME) happening while
> > interrupts are disabled.
>
> Good spotting... If any devices depend on what you describe, I would
> argue that their drivers should handle that not the core apm code...
The drivers can't handle it at the moment. I've been talking to many people
about this all hitting this sort of driver problem.
I think the fix is to keep two classes of power management objects and do
the following
Call each 'nonirq' suspend function
(aborting if need be)
cli()
Call each irq blocked suspend function
suspend
resume:
call each irq blocked resume function
sti();
call each nonirq resume
That is an easy change set to make and solves a lot of grief
next prev parent reply other threads:[~2001-06-11 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-11 17:57 Problems with arch/i386/kernel/apm.c Jeff Golds
2001-06-11 18:11 ` Jeff Garzik
2001-06-11 18:42 ` Alan Cox [this message]
2001-06-12 23:48 ` Patrick Mochel
2001-06-14 8:18 ` Alan Cox
2001-06-11 19:37 ` John Fremlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E159We4-0000Cc-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@mandrakesoft.com \
--cc=jgolds@resilience.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).