linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: adam@yggdrasil.com (Adam J. Richter)
Cc: linux-kernel@vger.kernel.org, deepak@plexity.net,
	alan@lxorguk.ukuu.org.uk
Subject: Re: PATCH: linux-2.4.9/drivers/i2o to new module_{init,exit} interface
Date: Mon, 20 Aug 2001 16:05:02 +0100 (BST)	[thread overview]
Message-ID: <E15Yqbv-0006BW-00@the-village.bc.nu> (raw)
In-Reply-To: <20010820072925.A296@baldur.yggdrasil.com> from "Adam J. Richter" at Aug 20, 2001 07:29:25 AM

> 	I'm not exactly sure where to send i2o patches, so I'm
> posting them to linux-kernel.  I would appreciate a pointer if there
> is a more specialized address for i2o patches.

Me for i2o

>  	sti();
> -#ifdef CONFIG_I2O
> -	i2o_init();
> -#endif
>  #ifdef CONFIG_BLK_DEV_DAC960
>  	DAC960_Initialize();

Rejected. The ordering is critical because drivers may have both i2o and
non i2o interfaces. Also an i2o card may control other pci devices and
we will need to claim the resources beforehand when we finally support that.

>  dep_tristate '  I2O Block OSM' CONFIG_I2O_BLOCK $CONFIG_I2O
> -if [ "$CONFIG_NET" = "y" ]; then
> +if [ "$CONFIG_NET" != "n" ]; then

NET cannot be modular

> -#ifdef MODULE
>  	i = core->install(c);
> -#else
> -	i = i2o_install_controller(c);
> -#endif /* MODULE */

This changes all the module dependancy patterns - yes its right, no its not
appropriate for a "stable" kernel.


  reply	other threads:[~2001-08-20 15:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-20 14:29 PATCH: linux-2.4.9/drivers/i2o to new module_{init,exit} interface Adam J. Richter
2001-08-20 15:05 ` Alan Cox [this message]
2001-08-20 15:15 Adam J. Richter
     [not found] <no.id>
2001-08-20 16:15 ` Alan Cox
2001-08-20 22:36 Adam J. Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E15Yqbv-0006BW-00@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=adam@yggdrasil.com \
    --cc=deepak@plexity.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).