From: tytso@mit.edu
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] loop device broken in 2.5.38
Date: Wed, 25 Sep 2002 13:35:06 -0400 [thread overview]
Message-ID: <E17uG42-0002gm-00@think.thunk.org> (raw)
The loop device driver was broken in 2.5.38 when it was converted over
to use gendisk. I discovered this while doing final regression testing
on the ext3 htree code.
The problem is that figure_loop_size() is setting the capacity of the
loop device in kilobytes (because that's what compute_loop_size()
returns), but set_capacity() expects the size in 512 byte sectors.
I've enclosed a patch which fixes the problem, as well as simplifying
the code by eliminating compute_loop_size(), since it is a static
function is only used once by figure_loop_size().
- Ted
===== drivers/block/loop.c 1.57 vs edited =====
--- 1.57/drivers/block/loop.c Sat Sep 21 02:08:48 2002
+++ edited/drivers/block/loop.c Wed Sep 25 13:28:37 2002
@@ -157,18 +157,12 @@
#define MAX_DISK_SIZE 1024*1024*1024
-static unsigned long
-compute_loop_size(struct loop_device *lo, struct dentry * lo_dentry)
-{
- loff_t size = lo_dentry->d_inode->i_mapping->host->i_size;
- return (size - lo->lo_offset) >> BLOCK_SIZE_BITS;
-}
-
static void figure_loop_size(struct loop_device *lo)
{
- set_capacity(disks + lo->lo_number, compute_loop_size(lo,
- lo->lo_backing_file->f_dentry));
-
+ loff_t size = lo->lo_backing_file->f_dentry->d_inode->i_size;
+
+ set_capacity(disks + lo->lo_number,
+ (size - lo->lo_offset) >> (BLOCK_SIZE_BITS-1));
}
static inline int lo_do_transfer(struct loop_device *lo, int cmd, char *rbuf,
next reply other threads:[~2002-09-25 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-25 17:35 tytso [this message]
2002-09-25 18:03 ` [PATCH] loop device broken in 2.5.38 Andreas Dilger
2002-09-25 20:12 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17uG42-0002gm-00@think.thunk.org \
--to=tytso@mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).