linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@arcor.de>
To: Richard.Zidlicky@stud.informatik.uni-erlangen.de, zippel@linux-m68k.org
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: 2.4 mm trouble [possible lru race]
Date: Tue, 1 Oct 2002 17:12:21 +0200	[thread overview]
Message-ID: <E17wOhB-0005uG-00@starship> (raw)
In-Reply-To: <200210011420.QAA13868@faui02b.informatik.uni-erlangen.de>

On Tuesday 01 October 2002 16:20, Richard.Zidlicky@stud.informatik.uni-erlangen.de wrote:
> > 
> > The theoretical lru race possibly spotted in the wild...
> > 
> > >
> > > Now I am wondering if that is just coincidence or why m68k hit that 
> > > error so reliably.. is it supposed to have any effect at all on
> > > UP?
> > 
> > Are you running UP+preempt?
> 
> no preempt or anything fancy, m68k vanila 2.4.19 (well almost).

I'm having real trouble spotting substantive change in the patch that
would affect a UP kernel.  I believe you when you say it fixes your
problem, but we don't know why, and it is worth making some effort to
find out why.

Ah wait, I see one candidate, would you like to try:

                 * the page as well.
                 */
                if (page->buffers) {
                        /* avoid to free a locked page */
-                       get_page(page);
                        spin_unlock(&pagemap_lru_lock);
+                       get_page(page);
 
and see if your bug comes back?  There are a couple of other changes
that could be considered substantive by stretching one's imagination
enough, but this is the leading candidate.

Oh wait, you could also try this, a little further down:

+                                       page_cache_release(page);
                                        spin_lock(&pagemap_lru_lock);
-                                       put_page_nofree(page);

By the way, the original patch you posted was reversed and your editor
apparently took the liberty of cleaning up some whitespace in the file.
Generally, we try do avoid patch chunks that just, e.g., change bogus
spaces to tabs, and save those for official whitespace patches.

-- 
Daniel

  reply	other threads:[~2002-10-01 15:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-01 14:20 Richard.Zidlicky
2002-10-01 15:12 ` Daniel Phillips [this message]
2002-10-01 15:29 ` Daniel Phillips
2002-10-01 16:56   ` Rik van Riel
2002-10-01 17:10     ` Daniel Phillips
2002-10-01 17:31       ` Jens Axboe
2002-10-01 18:01         ` Daniel Phillips
2002-10-01 18:04           ` Jens Axboe
2002-10-01 18:14             ` Daniel Phillips
2002-10-01 18:22               ` Rik van Riel
2002-10-02 12:07               ` Geert Uytterhoeven
2002-10-02  9:45           ` Richard Zidlicky
  -- strict thread matches above, loose matches on Subject: below --
2002-10-20 14:37 Richard Zidlicky
     [not found] <20020925122439.C198@linux-m68k.org>
     [not found] ` <Pine.LNX.4.44.0209281634240.338-100000@serv>
     [not found]   ` <20021001112229.A235@linux-m68k.org>
2002-10-01 10:26     ` Daniel Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E17wOhB-0005uG-00@starship \
    --to=phillips@arcor.de \
    --cc=Richard.Zidlicky@stud.informatik.uni-erlangen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=zippel@linux-m68k.org \
    --subject='Re: 2.4 mm trouble [possible lru race]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).