From: Miklos Szeredi <miklos@szeredi.hu>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Can't unmount bad inode
Date: Wed, 19 Jan 2005 22:58:40 +0100 [thread overview]
Message-ID: <E1CrNqa-0001Nq-00@dorka.pomaz.szeredi.hu> (raw)
In-Reply-To: <20050119214519.GG26051@parcelfarce.linux.theplanet.co.uk> (message from Al Viro on Wed, 19 Jan 2005 21:45:19 +0000)
> > This patch fixes a problem when a inode which is the root of a mount
> > becomes bad (make_bad_inode()). In this case follow_link will return
> > -EIO, so the name resolution fails, and umount won't work. The
> > solution is just to remove the follow_link method from bad_inode_ops.
> > Any filesystem operation (other than unmount) will still fail, since
> > every other method returns -EIO.
>
> I'm not all that sure that we want to follow symlinks in the last
> pathname component upon umount, actually...
That could break existing usage, couldn't it? The damage wouldn't be
too bad I guess, but still it would be a bigger change, than fixing
bad_inode.
Miklos
prev parent reply other threads:[~2005-01-19 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 21:20 [PATCH] Can't unmount bad inode Miklos Szeredi
2005-01-19 21:45 ` Al Viro
2005-01-19 21:58 ` Miklos Szeredi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1CrNqa-0001Nq-00@dorka.pomaz.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).