From: Chuck Lever <chuck.lever@oracle.com>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: Bruce Fields <bfields@fieldses.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: Use seq_putc() in two functions
Date: Sat, 4 Jul 2020 10:31:46 -0400 [thread overview]
Message-ID: <E1D55112-90D0-4B1E-AB57-74F2C782F973@oracle.com> (raw)
In-Reply-To: <20200618015613.17806-1-vulab@iscas.ac.cn>
Hi-
> On Jun 17, 2020, at 9:56 PM, Xu Wang <vulab@iscas.ac.cn> wrote:
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc()".
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Applied to nfsd-5.9. Thanks.
> ---
> fs/nfsd/nfs4idmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
> index 9460be8a8321..f92161ce1f97 100644
> --- a/fs/nfsd/nfs4idmap.c
> +++ b/fs/nfsd/nfs4idmap.c
> @@ -168,7 +168,7 @@ idtoname_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h)
> ent->id);
> if (test_bit(CACHE_VALID, &h->flags))
> seq_printf(m, " %s", ent->name);
> - seq_printf(m, "\n");
> + seq_putc(m, '\n');
> return 0;
> }
>
> @@ -346,7 +346,7 @@ nametoid_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h)
> ent->name);
> if (test_bit(CACHE_VALID, &h->flags))
> seq_printf(m, " %u", ent->id);
> - seq_printf(m, "\n");
> + seq_putc(m, '\n');
> return 0;
> }
>
> --
> 2.17.1
>
--
Chuck Lever
prev parent reply other threads:[~2020-07-04 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 1:56 [PATCH] nfsd: Use seq_putc() in two functions Xu Wang
2020-07-04 14:31 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1D55112-90D0-4B1E-AB57-74F2C782F973@oracle.com \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).