From: Matthew Garrett <mgarrett@chiark.greenend.org.uk>
To: Ben Collins <bcollins@ubuntu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/15] sonypi: Enable ACPI events for Sony laptop hotkeys
Date: Thu, 5 Jan 2006 09:25:24 +0000 [thread overview]
Message-ID: <E1EuRN6-0006Hu-00@chiark.greenend.org.uk> (raw)
In-Reply-To: <0ISL001SM95JWW@a34-mta01.direcway.com>
Ben Collins <bcollins@ubuntu.com> wrote:
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
This one's a bit of a hack - it pushes Sony hotkey magic stuff through
the ACPI layer for the sake of consistency, despite the fact that
there's not actually any ACPI involved.
The "right" way is probably actually to push ACPI hotkey events through
the input layer (like the Sony code does without this patch), but that's
currently a bit more awkward to handle in userspace. Since the right
answer here is clearly "Fix userspace", we probably don't want to be
merging this.
(Disclaimer: I wrote it originally because it was easier than fixing
userspace...)
--
Matthew Garrett | mjg59-chiark.mail.linux-rutgers.kernel@srcf.ucam.org
next prev parent reply other threads:[~2006-01-05 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 22:00 [PATCH 08/15] sonypi: Enable ACPI events for Sony laptop hotkeys Ben Collins
2006-01-05 7:55 ` Jan Engelhardt
2006-01-05 9:25 ` Matthew Garrett [this message]
2006-01-15 20:49 ` Jan Engelhardt
2006-01-16 0:21 ` Matthew Garrett
2006-01-16 12:00 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1EuRN6-0006Hu-00@chiark.greenend.org.uk \
--to=mgarrett@chiark.greenend.org.uk \
--cc=bcollins@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).