From: Andreas Dilger <adilger@dilger.ca>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.com>,
y2038@lists.linaro.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] jbd2: replace current_kernel_time64 with ktime equivalent
Date: Thu, 21 Jun 2018 11:32:47 -0600 [thread overview]
Message-ID: <E233989D-59D7-4257-A50B-F2AFCB2ED8DF@dilger.ca> (raw)
In-Reply-To: <20180620153322.54221-5-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
> On Jun 20, 2018, at 9:33 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> jbd2 is one of the few callers of current_kernel_time64(), which
> is a wrapper around ktime_get_coarse_real_ts64(). This calls the
> latter directly for consistency with the rest of the kernel that
> is moving to the ktime_get_ family of time accessors.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/jbd2/commit.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
> index 8de0e7723316..150cc030b4d7 100644
> --- a/fs/jbd2/commit.c
> +++ b/fs/jbd2/commit.c
> @@ -121,7 +121,7 @@ static int journal_submit_commit_record(journal_t *journal,
> struct commit_header *tmp;
> struct buffer_head *bh;
> int ret;
> - struct timespec64 now = current_kernel_time64();
> + struct timespec64 now;
>
> *cbh = NULL;
>
> @@ -134,6 +134,7 @@ static int journal_submit_commit_record(journal_t *journal,
> return 1;
>
> tmp = (struct commit_header *)bh->b_data;
> + ktime_get_coarse_real_ts64(&now);
> tmp->h_commit_sec = cpu_to_be64(now.tv_sec);
> tmp->h_commit_nsec = cpu_to_be32(now.tv_nsec);
>
> --
> 2.9.0
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
next prev parent reply other threads:[~2018-06-21 17:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 15:32 [PATCH 1/6] ext4: sysfs: print ext4_super_block fields as little-endian Arnd Bergmann
2018-06-20 15:32 ` [PATCH 2/6] ext4: use 64-bit timestamps for mmp_time Arnd Bergmann
2018-06-21 17:20 ` Andreas Dilger
2018-06-22 7:38 ` Jan Kara
2018-06-20 15:33 ` [PATCH 3/6] ext4: use ktime_get_real_seconds for i_dtime Arnd Bergmann
2018-06-21 17:27 ` Andreas Dilger
2018-06-21 20:07 ` Arnd Bergmann
2018-06-20 15:33 ` [PATCH 4/6] ext4: use timespec64 for all inode times Arnd Bergmann
2018-06-21 17:29 ` Andreas Dilger
2018-06-22 7:37 ` Jan Kara
2018-06-22 8:15 ` Arnd Bergmann
2018-06-20 15:33 ` [PATCH 5/6] jbd2: replace current_kernel_time64 with ktime equivalent Arnd Bergmann
2018-06-21 17:32 ` Andreas Dilger [this message]
2018-06-22 7:41 ` Jan Kara
2018-06-20 15:33 ` [PATCH 6/6] [RFC] ext4: super: extend timestamps to 40 bits Arnd Bergmann
2018-06-21 17:46 ` Andreas Dilger
2018-06-21 20:17 ` Arnd Bergmann
2018-06-21 17:49 ` [PATCH 1/6] ext4: sysfs: print ext4_super_block fields as little-endian Andreas Dilger
2018-06-21 20:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E233989D-59D7-4257-A50B-F2AFCB2ED8DF@dilger.ca \
--to=adilger@dilger.ca \
--cc=arnd@arndb.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).