From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C47C35E0E for ; Tue, 25 Feb 2020 21:43:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B05820675 for ; Tue, 25 Feb 2020 21:43:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=easyb-ch.20150623.gappssmtp.com header.i=@easyb-ch.20150623.gappssmtp.com header.b="oveJUVfN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729111AbgBYVnE (ORCPT ); Tue, 25 Feb 2020 16:43:04 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40119 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729080AbgBYVnD (ORCPT ); Tue, 25 Feb 2020 16:43:03 -0500 Received: by mail-wm1-f68.google.com with SMTP id t14so821606wmi.5 for ; Tue, 25 Feb 2020 13:43:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=easyb-ch.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=kEVJ1n2NxQ1glfbZ9e15foebWC3MxMe0p/5A/jyD6H0=; b=oveJUVfN4mGmIby/KrplpWvi32NOCpmb1Fej6u+eU25j1sso9bxSCmnS1HYlP5k+TS MN55kLyOOXTrI5QiCGtP00bRnkJxE6q+aUpqdFsAsXwQh0dvu55FS/TXrAVS/ae6mu1l NAlvopKlSspPGtPCVj0mdTNuFv+ZfhgIinLqRNatsNKvQI8KxR0B1VAiDYp321L4gtUZ g8u+mkFIDr2NdhUV2f4JbQ3BTA7fhSsIoCINRAOSYNlefs7F0PuxzSG5YkiVtBklT+fO oaD/MUhWA0PqDh9MWO9s+RAgppI/P3ICunuQwVb2PDrJVH31q6jq8+vTKG+aECdrMlUL Kc9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=kEVJ1n2NxQ1glfbZ9e15foebWC3MxMe0p/5A/jyD6H0=; b=rEXxctg0eZK6RklFrLOn9Svndp6qRd5Va5MEhQhGXBA5j78QdUc5KDicJjKrHQuWEC 44pi1YcKohuvdVxjGSdG9rLD6G156vjogOiV2l2P34sSzyH9yDOeL75i9WuUkQXAcuuZ +y/5JNDk3cW4Pt9EqnOcUH1dBRMWG3EgGPQp8MNdzlWsP0/2n5+YI7p0UKWUxwr9X2N5 SFGANbWn/JKKiirzQsx4qbyVvuXJvWrmbkCRakHc+4LiAAooj8DznUIhvkudfwM7zG1v W0ltXspj7SX80scucrtXqusP6YvheyovSAvcCd3DNUSt2f3W7TeC+7N5STJjfy5Wz7xw qx+w== X-Gm-Message-State: APjAAAWDJGnmg73G5T2CZlHVELx0lzXaXZR4EDPG9rOVYhRLda5PPvwL fOupFOEm2ghcyzqvH4NLYjwc0g== X-Google-Smtp-Source: APXvYqzT6vU3uivqK3LFISSNim+ES8rBV5I3PSPpMQoyPtAT6binkjIz4QcxUjjxxm7ATqtLrWgIdA== X-Received: by 2002:a1c:7ec5:: with SMTP id z188mr1188559wmc.52.1582666980570; Tue, 25 Feb 2020 13:43:00 -0800 (PST) Received: from ?IPv6:2001:1715:4e22:c580:ed96:156f:9663:e7e4? ([2001:1715:4e22:c580:ed96:156f:9663:e7e4]) by smtp.gmail.com with ESMTPSA id f1sm212602wro.85.2020.02.25.13.42.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Feb 2020 13:43:00 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [RFC 00/25] arm64: realtek: Add Xnano X5 and implement TM1628/FD628/AiP1618 LED controllers From: Ezra Buehler In-Reply-To: <04e7d7cd-a8bc-621b-9205-1a058521cabe@arm.com> Date: Tue, 25 Feb 2020 22:42:57 +0100 Cc: linux-realtek-soc@lists.infradead.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , csd@princeton.com.tw, devicetree@vger.kernel.org, sales@fdhisi.com, Mark Brown , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Rob Herring , Jacek Anaszewski , Pavel Machek , zypeng@titanmec.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dan Murphy , linux-rockchip@lists.infradead.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20191212033952.5967-1-afaerber@suse.de> <7110806f-ddbd-f055-e107-7a1f7e223102@arm.com> <04e7d7cd-a8bc-621b-9205-1a058521cabe@arm.com> To: Robin Murphy , =?utf-8?Q?Andreas_F=C3=A4rber?= X-Mailer: Apple Mail (2.3445.9.1) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, Hi Andreas, > On 13 Dec 2019, at 15:07, Robin Murphy wrote: >=20 > I also have one of the H96 Max boxes (which I picked up out of = curiosity > for the mysterious RK3318) with an FD6551, although I've not attacked > that one with the logic analyser yet to see how similar it is. I have a T9 (RK3328) TV box with the same chip in it. The FD6551 uses an I2C-like protocol. Every digit (and the symbols) have an I2C address, but, the display does not signal ACK. AFAIK the FD650 and FD655 which are used in other boxes (Amlogic) are very similar. So far, I have whipped up a proof-of-cocept driver that uses i2c-gpio. The digits seem to be rotated by 180 degrees. So, in order to use map_to_7segment.h I had to define the BIT_SEG7_* constants differently. My display also has multiple symbols (WIFI, network, pause, play, USB, alarm) that are controlled by writing to the same address as for the colon. I=E2=80=99d love to work on a driver (similar to Andreas=E2=80=99 SPI = based driver) for these I2C connected chips. Cheers, Ezra.