From: "Arulprabhu Ponnusamy (arulponn)" <arulponn@cisco.com>
To: "Karan Tilak Kumar (kartilak)" <kartilak@cisco.com>,
"Satish Kharat (satishkh)" <satishkh@cisco.com>
Cc: "Sesidhar Baddela (sebaddel)" <sebaddel@cisco.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: fnic: Change shost_printk to FNIC_MAIN_DBG
Date: Tue, 24 Nov 2020 01:14:40 +0000 [thread overview]
Message-ID: <E34F9542-55FC-41EA-B757-9BBDCD6331C0@cisco.com> (raw)
In-Reply-To: <20201121013739.18701-1-kartilak@cisco.com>
Looks good.
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
On 11/20/20, 5:38 PM, "Karan Tilak Kumar" <kartilak@cisco.com> wrote:
Replacing shost_printk with FNIC_MAIN_DBG so that
these log messages are controlled by fnic_log_level
flag in fnic_handle_link.
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Signed-off-by: Satish Kharat <satishkh@cisco.com>
---
drivers/scsi/fnic/fnic.h | 2 +-
drivers/scsi/fnic/fnic_fcs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h
index 6dc8c916de31..7c5c911b2673 100644
--- a/drivers/scsi/fnic/fnic.h
+++ b/drivers/scsi/fnic/fnic.h
@@ -39,7 +39,7 @@
#define DRV_NAME "fnic"
#define DRV_DESCRIPTION "Cisco FCoE HBA Driver"
-#define DRV_VERSION "1.6.0.50"
+#define DRV_VERSION "1.6.0.51"
#define PFX DRV_NAME ": "
#define DFX DRV_NAME "%d: "
diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
index 3337d6627baf..e0cee4dcb439 100644
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -75,7 +75,7 @@ void fnic_handle_link(struct work_struct *work)
atomic64_set(&fnic->fnic_stats.misc_stats.current_port_speed,
new_port_speed);
if (old_port_speed != new_port_speed)
- shost_printk(KERN_INFO, fnic->lport->host,
+ FNIC_MAIN_DBG(KERN_INFO, fnic->lport->host,
"Current vnic speed set to : %llu\n",
new_port_speed);
--
2.29.2
next prev parent reply other threads:[~2020-11-24 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 1:37 [PATCH] scsi: fnic: Change shost_printk to FNIC_MAIN_DBG Karan Tilak Kumar
2020-11-24 1:14 ` Arulprabhu Ponnusamy (arulponn) [this message]
2020-11-24 3:56 ` Joe Perches
2022-05-12 20:21 ` Karan Tilak Kumar (kartilak)
2020-11-24 3:48 ` Martin K. Petersen
2020-12-01 5:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E34F9542-55FC-41EA-B757-9BBDCD6331C0@cisco.com \
--to=arulponn@cisco.com \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).