From: "Benjamin Coddington" <bcodding@redhat.com>
To: "Trond Myklebust" <trondmy@hammerspace.com>
Cc: bfields@fieldses.org, tibbs@math.uh.edu, linux@stwm.de,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
km@cm4all.com, chuck.lever@oracle.com
Subject: Re: Regression in 5.1.20: Reading long directory fails
Date: Thu, 12 Sep 2019 09:35:08 -0400 [thread overview]
Message-ID: <E3D5BD21-8D9D-4EBE-A607-5D4BC9692C63@redhat.com> (raw)
In-Reply-To: <db42c87ba2c5b0852ad42ba51792ee67ab036a37.camel@hammerspace.com>
On 12 Sep 2019, at 9:25, Trond Myklebust wrote:
> On Thu, 2019-09-12 at 09:13 -0400, J. Bruce Fields wrote:
>> (Unless I'm missing something. I haven't looked at this code in a
>> while. Though it was problem me that wrote it originally--apologies
>> for
>> that....)
>>
>
> The function itself is fine. It was just the name I'm objecting to,
> since we're actually moving the last 'n' bytes in the message in order
> to be able to read them.
Ok, that's helpful guidance since it saves me from doing a stable fix and
then an attempt to rename/optimize/breakitagain.
I'll just rename it at the same time as the fix.. but now I wonder if that
can potentially mess up other fixes that might retroactively get sent to
stable. Maybe I'm over thinking it. I guess I'll send the fix and then the
rename separately, and maintainers can squash at will.
Ben
next prev parent reply other threads:[~2019-09-12 13:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ufak1bhyuew.fsf@epithumia.math.uh.edu>
2019-08-22 19:39 ` Regression in 5.1.20: Reading long directory fails Jason L Tibbitts III
2019-08-28 17:46 ` J. Bruce Fields
2019-08-28 18:29 ` Jason L Tibbitts III
2019-08-28 18:33 ` J. Bruce Fields
2019-09-03 15:49 ` Jason L Tibbitts III
2019-09-03 18:02 ` Wolfgang Walter
2019-09-03 19:06 ` Jason L Tibbitts III
2019-09-03 19:08 ` Chuck Lever
2019-09-03 21:37 ` Wolfgang Walter
2019-09-04 1:50 ` Jason L Tibbitts III
2019-09-06 14:48 ` J. Bruce Fields
2019-09-06 20:47 ` Jason L Tibbitts III
2019-09-06 20:50 ` Chuck Lever
2019-09-08 11:39 ` Benjamin Coddington
2019-09-08 15:19 ` Trond Myklebust
2019-09-08 15:48 ` Chuck Lever
2019-09-08 16:47 ` Trond Myklebust
2019-09-08 16:51 ` Chuck Lever
2019-09-11 16:25 ` Benjamin Coddington
2019-09-11 16:39 ` Chuck Lever
2019-09-11 17:26 ` Benjamin Coddington
2019-09-11 17:27 ` Benjamin Coddington
2019-09-11 17:29 ` Chuck Lever
2019-09-11 17:40 ` Benjamin Coddington
2019-09-11 17:43 ` Chuck Lever
2019-09-11 17:59 ` Benjamin Coddington
2019-09-11 17:50 ` Benjamin Coddington
2019-09-11 17:54 ` Chuck Lever
2019-09-12 12:29 ` Benjamin Coddington
2019-09-12 12:53 ` Trond Myklebust
2019-09-12 13:08 ` Benjamin Coddington
2019-09-12 13:13 ` J. Bruce Fields
2019-09-12 13:25 ` Trond Myklebust
2019-09-12 13:35 ` Benjamin Coddington [this message]
2019-09-12 13:14 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3D5BD21-8D9D-4EBE-A607-5D4BC9692C63@redhat.com \
--to=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=km@cm4all.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux@stwm.de \
--cc=tibbs@math.uh.edu \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).