From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040AbdFVQKI (ORCPT ); Thu, 22 Jun 2017 12:10:08 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33197 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdFVQKH (ORCPT ); Thu, 22 Jun 2017 12:10:07 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH v3 11/11] x86/mm: Try to preserve old TLB entries using PCID From: Nadav Amit In-Reply-To: Date: Thu, 22 Jun 2017 09:09:56 -0700 Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Linus Torvalds , Andrew Morton , Mel Gorman , "linux-mm@kvack.org" , Rik van Riel , Dave Hansen , Arjan van de Ven , Peter Zijlstra Content-Transfer-Encoding: 7bit Message-Id: References: To: Andy Lutomirski X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Lutomirski wrote: > > --- a/arch/x86/mm/init.c > +++ b/arch/x86/mm/init.c > @@ -812,6 +812,7 @@ void __init zone_sizes_init(void) > > DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) = { > .loaded_mm = &init_mm, > + .next_asid = 1, I think this is a remainder from previous version of the patches, no? It does not seem necessary and may be confusing (ctx_id 0 is reserved, but not asid 0). Other than that, if you want, you can put for the entire series: Reviewed-by: Nadav Amit