* [PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node
@ 2019-02-11 16:20 Andreas Kemnade
2019-02-11 18:14 ` [Letux-kernel] " H. Nikolaus Schaller
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Kemnade @ 2019-02-11 16:20 UTC (permalink / raw)
To: bcousson, tony, robh+dt, mark.rutland, linux-omap, devicetree,
linux-kernel, letux-kernel
Cc: Andreas Kemnade
The lcd display of the gta04 has a backlight but the backlight
was not referenced in the lcd node, so screen blanking did
not turn off the backlight. Fix that.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
the backlight property for the driver was accepted here:
https://lore.kernel.org/lkml/a54e7427-ff84-d105-aab7-c5eab42e6df9@ti.com/
arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 8c55d33ff694..3b88eb5f1a72 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -142,6 +142,7 @@
spi-cpol;
spi-cpha;
+ backlight= <&backlight>;
label = "lcd";
port {
lcd_in: endpoint {
@@ -151,7 +152,7 @@
};
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm11 0 12000000 0>;
pwm-names = "backlight";
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node
2019-02-11 16:20 [PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node Andreas Kemnade
@ 2019-02-11 18:14 ` H. Nikolaus Schaller
2019-02-13 15:49 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: H. Nikolaus Schaller @ 2019-02-11 18:14 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Benoit Cousson, Tony Lindgren, Rob Herring, Mark Rutland,
linux-omap, devicetree, LKML, Discussions about the Letux Kernel
> Am 11.02.2019 um 17:20 schrieb Andreas Kemnade <andreas@kemnade.info>:
>
> The lcd display of the gta04 has a backlight but the backlight
> was not referenced in the lcd node, so screen blanking did
> not turn off the backlight. Fix that.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Works fine.
Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> the backlight property for the driver was accepted here:
> https://lore.kernel.org/lkml/a54e7427-ff84-d105-aab7-c5eab42e6df9@ti.com/
>
> arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> index 8c55d33ff694..3b88eb5f1a72 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -142,6 +142,7 @@
> spi-cpol;
> spi-cpha;
>
> + backlight= <&backlight>;
> label = "lcd";
> port {
> lcd_in: endpoint {
> @@ -151,7 +152,7 @@
> };
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm11 0 12000000 0>;
> pwm-names = "backlight";
> --
> 2.11.0
>
> _______________________________________________
> http://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node
2019-02-11 18:14 ` [Letux-kernel] " H. Nikolaus Schaller
@ 2019-02-13 15:49 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2019-02-13 15:49 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Andreas Kemnade, Benoit Cousson, Rob Herring, Mark Rutland,
linux-omap, devicetree, LKML, Discussions about the Letux Kernel
* H. Nikolaus Schaller <hns@goldelico.com> [190211 18:14]:
>
> > Am 11.02.2019 um 17:20 schrieb Andreas Kemnade <andreas@kemnade.info>:
> >
> > The lcd display of the gta04 has a backlight but the backlight
> > was not referenced in the lcd node, so screen blanking did
> > not turn off the backlight. Fix that.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>
> Works fine.
>
> Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
Thanks applied into omap-for-v5.1/dt.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-13 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 16:20 [PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node Andreas Kemnade
2019-02-11 18:14 ` [Letux-kernel] " H. Nikolaus Schaller
2019-02-13 15:49 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).