From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753558AbdF1Bon (ORCPT ); Tue, 27 Jun 2017 21:44:43 -0400 Received: from mail-dm3nam03on0052.outbound.protection.outlook.com ([104.47.41.52]:4960 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752694AbdF1Boe (ORCPT ); Tue, 27 Jun 2017 21:44:34 -0400 From: "Madhani, Himanshu" To: "Martin K. Petersen" , Johannes Thumshirn CC: Linux SCSI Mailinglist , Linux Kernel Mailinglist , Dept-Eng QLA2xxx Upstream , Hannes Reinecke , John Garry Subject: Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock Thread-Topic: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock Thread-Index: AQHS6+/hvui4g7XsLECAwrSpzEYl+KI5hNrs//+OGAA= Date: Wed, 28 Jun 2017 01:44:31 +0000 Message-ID: References: <20170623071011.21184-1-jthumshirn@suse.de> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR07MB3454;7:Q/fCThPDYOKoXKKB6gzcOZ5BRoY5ltq7jKbGcPRY+w6ExkmhQErwI5Ia+yCVrhYjiAsqiAu4w+6/qHHPfq/uSfOQut7Ba7gR2MMBde5KQA4+40ksuZx+lPUT8Y5sAIjr/oep+akuK9ueL9YA7AcRddZ2IZToOUjqyqVXzxaVQ+v48GItP03v0yLfiysRWHJxQ0Mr4qr2pmV0pnzDVw5wgtjOskCCAr5jxN3HqvaC3jkiUkNh3b//Rx9zp/9n4OBhYsFIJnq/kjQh+OfPR3U1gEJ60+2k+2/CvzUMuBPIzzhWfpcROV/i5G1+MRb/iQgMHquYkSwCUAgnExlahJg7fxnwgXFmBKbrRyMy8kVbYUS9Q+ViWIoIAojydmPOSGFiGaOnkierfIIEm+19YXrG8wUap4TR5bgqkHzTJHwm6aATUj5pmTwrt0Citjmcdwc2qIN2wX29v+vycdqWJ9+N07Zpl/PcA/zRc75xszQZimUj7sAXygZJcegd9Cx2LLY1wfVigmF7tgWBBGxs3t3y9i+N83JjpllN3Sd9wO2vNA1gfRUtwSUWvBJhJUxWGRJ8/GXE0eQorFV1sVPp2Gtgp+krAXO3P869dacR6tpYI2VG6Tf1XAqoMyb8n0Q2COD5DoHIy7jOYlMrVrHKL9oQBEKPBvCTp0TwjePBAAKwvJXT7CsVkR2qI5GmS/owS8IZBmFf/u6HlVWQ5D1gdCI458EbKy0a2WUY7RmyxqkquQycwo74fFSRaIAwVJW5dod+h8MtStTr/xk9b8tiB1699RPv5nLhJ+c3wfjNU8ANNeA= x-ms-office365-filtering-correlation-id: 4eba84d9-4e63-4a70-7abd-08d4bdc738b2 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506072)(300135500095);SRVR:MWHPR07MB3454; x-ms-traffictypediagnostic: MWHPR07MB3454: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(236129657087228)(167848164394848)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3454;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3454; x-forefront-prvs: 03524FBD26 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(39840400002)(39450400003)(39850400002)(39410400002)(39400400002)(24454002)(377454003)(77096006)(53546010)(6512007)(3846002)(33656002)(2900100001)(50986999)(86362001)(5660300001)(3280700002)(8676002)(81166006)(102836003)(76176999)(54356999)(478600001)(36756003)(8936002)(305945005)(6116002)(14454004)(72206003)(3660700001)(25786009)(82746002)(2906002)(54906002)(99286003)(2950100002)(6436002)(189998001)(6506006)(83716003)(7736002)(229853002)(38730400002)(6486002)(66066001)(4326008)(6246003)(53936002)(427584002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3454;H:MWHPR07MB3455.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <411C0DB3FF271B4085E344B736582C05@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2017 01:44:31.1257 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3454 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5S1ilfu004802 Hi Martin, On 6/27/17, 6:32 PM, "Martin K. Petersen" wrote: > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to qpair > members under the qpair->qp_lock. Cavium folks, please review! I am testing it internally, will update by tomorrow. -- Martin K. Petersen Oracle Linux Engineering Thanks, Himanshu