From: "Levy, Amir (Jer)" <amir.jer.levy@intel.com>
To: Andreas Noever <andreas.noever@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
thunderbolt-linux <thunderbolt-linux@intel.com>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"Winkler, Tomas" <tomas.winkler@intel.com>
Subject: RE: [PATCH v6 2/8] thunderbolt: Updating the register definitions
Date: Sun, 11 Sep 2016 13:19:38 +0000 [thread overview]
Message-ID: <E607265CB020454880711A6F96C05A03AA3F434E@hasmsx107.ger.corp.intel.com> (raw)
In-Reply-To: <CAMxnaaUnY5XtXWpYPbeZiXqEJYJ6_RprCPCEwG-_G4NB3PUTNQ@mail.gmail.com>
On Sun, Sep 11 2016, 03:02 AM, Andreas Noever wrote:
> On Mon, Aug 1, 2016 at 2:23 PM, Amir Levy <amir.jer.levy@intel.com> wrote:
> > Adding more Thunderbolt(TM) register definitions and some helper
> > macros.
>
> Thinking about this again I would prefer it if you would put your definitions
> into a separate file under icm/ (even if there is some duplication). The style
> (bitfields vs. genmask) is different between the drivers and for a reader it is
> difficult to find out what is actually supposed to be used by the two drivers
> (ring_desc vs tbt_buf_desc or the ring RING_INT_EN/DISABLE macros in the
> header file vs. ring_interrupt_active in nhi.c).
>
> This would also completely separate the two drivers.
>
> Andreas
>
I'm also in favor of completely separating the drivers, but is it the right thing to do with the register definitions
when the underlying registers layout is exactly the same?
Note that bitfields are not so recommended when you care about the format/order of bits, like in the ring descriptor.
Amir
next prev parent reply other threads:[~2016-09-11 13:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 12:23 [PATCH v6 0/8] thunderbolt: Introducing Thunderbolt(TM) networking Amir Levy
2016-08-01 12:23 ` [PATCH v6 1/8] thunderbolt: Macro rename Amir Levy
2016-09-10 23:20 ` Andreas Noever
2016-08-01 12:23 ` [PATCH v6 2/8] thunderbolt: Updating the register definitions Amir Levy
2016-09-11 0:02 ` Andreas Noever
2016-09-11 13:19 ` Levy, Amir (Jer) [this message]
2016-08-01 12:23 ` [PATCH v6 3/8] thunderbolt: Kconfig for Thunderbolt(TM) networking Amir Levy
2016-08-31 11:29 ` Greg KH
2016-08-31 11:30 ` Greg KH
2016-08-01 12:23 ` [PATCH v6 4/8] thunderbolt: Communication with the ICM (firmware) Amir Levy
2016-08-31 11:34 ` Greg KH
2016-08-01 12:23 ` [PATCH v6 5/8] thunderbolt: Networking state machine Amir Levy
2016-08-31 11:35 ` Greg KH
2016-08-01 12:23 ` [PATCH v6 6/8] thunderbolt: Networking transmit and receive Amir Levy
2016-08-01 12:23 ` [PATCH v6 7/8] thunderbolt: Networking doc Amir Levy
2016-08-31 11:39 ` Greg KH
2016-08-01 12:23 ` [PATCH v6 8/8] thunderbolt: Adding maintainer entry Amir Levy
2016-08-31 11:28 ` [PATCH v6 0/8] thunderbolt: Introducing Thunderbolt(TM) networking Greg KH
2016-09-10 23:19 ` Andreas Noever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E607265CB020454880711A6F96C05A03AA3F434E@hasmsx107.ger.corp.intel.com \
--to=amir.jer.levy@intel.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=thunderbolt-linux@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).