From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Grazvydas Ignotas <notasas@gmail.com>,
Andreas Kemnade <andreas@kemnade.info>,
linux-pm@vger.kernel.org, letux-kernel@openphoenux.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present
Date: Wed, 3 May 2017 14:20:29 +0200 [thread overview]
Message-ID: <E634AF27-5FD1-4729-AB06-3DAFE63A5FC2@goldelico.com> (raw)
In-Reply-To: <20170501112631.2kz4bbga4hfznhsz@earth>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
> Am 01.05.2017 um 13:26 schrieb Sebastian Reichel <sebastian.reichel@collabora.co.uk>:
>
> Hi,
>
> On Fri, Apr 14, 2017 at 09:29:38PM +0200, H. Nikolaus Schaller wrote:
>> We can't assume that the battery is or stays present after probing
>> on devices with replaceable battery.
>>
>> On some devices (e.g. GTA04 or OpenPanodra) it can be removed
>> and even be hot swapped by the user while device continues to operate
>> through external AC or USB power (as long as system power consumption
>> remains below ca. 500mA as provided by USB). Under certain conditions
>> it is possible to boot without battery.
>>
>> So it makes no sense to check for this situation during probe and make
>> the charger driver (and its status reports) completely non-operational if
>> the battery can be inserted later.
>>
>> Tested on: GTA04 and OpenPandora.
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> Thanks, queued.
TNX,
Nikolaus
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-05-03 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 19:29 [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present H. Nikolaus Schaller
2017-05-01 11:26 ` Sebastian Reichel
2017-05-03 12:20 ` H. Nikolaus Schaller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E634AF27-5FD1-4729-AB06-3DAFE63A5FC2@goldelico.com \
--to=hns@goldelico.com \
--cc=andreas@kemnade.info \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).